Am 02.05.2013 22:09, schrieb Michael Heydekamp:

>> As long as I was using 0.9-git, I didn't have all those wrapping issues I
>> described in my recent messages. Except a specific counting problem which I
>> still need to test with the current routine.
> 
> This needs still to be tested.

Has just been tested. For the sake of completeness and clarity, I'd like to
confirm that the issue described in the message attached, appears to be
resolved in the meantime. Most likely thanks to the new wrapping routine,
which did invent some new bugs on one hand, but at least fixed this one (and
probably other ones) on the other hand. Plus the ones that have been fixed
in the past days/week.

Interestingly, 1.0-git of March 17th still had this bug, the current 1.0-git
I'm now using [GIT 20130503.1233] doesn't appear to have it. So the new
wrapping routine must have been invented/committed after March 17th.

I may have missed that, as the SVN list had a severe leak - apparently due
to an outage of the mailing list servers - between Mar 20th (10:43) and Mar
25th (09:11), so I haven't been able to notice the commits during this
leakage.

Cheers,
-- 
Michael Heydekamp
Co-Admin freexp.de
Düsseldorf/Germany
--- Begin Message ---
Am 18.01.2013 20:29, schrieb Thomas Bruederli:
On Tue, Jan 15, 2013 at 1:13 AM, Michael Heydekamp <listu...@freexp.de> wrote:

The message quoted below sounds ridiculous, as both texts do look exacly
the same. The reason apparently is that I copied the first paragraph from
the original mail being in the Sent folder, where the lines were wrapped
already after pos. #76 (so each line had an LF at the end).

So it wasn't a forward problem but rather copy & paste?

No. But see below.

But upon typing, everything is flowed in the editor and therefore there are
no LFs at all. So here's how the first x'ed paragraph in the quoted mail
below should look like when you type it (and are using the settings
described further below):

You're writing about "the editor". Did you use the HTML editor or
plaintext mail composition?

In my initial post of this thread, I wrote:

------------------------------------------------
When I'm sending a plain text message [...]
------------------------------------------------

However, I generally fail to understand and reproduce your problem.
Could you describe exactly what you did step by step?

Sure. But first I'd like to suggest - no, I request - to make 'send_format_flowed' and 'line_length' user-configurable. To demonstrate the issue in this post, I had to change 'send_format_flowed' to true, which no normal user would be able to, as he hasn't access to main.inc.php.

Ok, here we go (required config settings 'send_format_flowed=false', 'line_length=76'):


Step #1 - we type this plain text:
----------------------------------

xxxäxxxx xxxxx xxx xxxxx xxxäxxxxx xxxxxx xxxxx xxxxxx xxxxxxxxxx xxxxxxxxxx. xxxx xxxxx xxxxx xxxx xx xx.xx. xxxxxx xxxxxxxxxxxx, xxxx xx xxx xxxx xxxxxxxxxx xxxx xxx xxxxxxxx xxßxx, xxxxx xxx xxxxxx xxx xxxx xxx xxxxxx xxxxx xxxx xx xxxxxxx xxxxxx "xxx xxx xxx xxxxxxx".


Step #2 - we send the message, it will be wrapped like this:
------------------------------------------------------------

xxxäxxxx xxxxx xxx xxxxx xxxäxxxxx xxxxxx xxxxx xxxxxx xxxxxxxxxx
xxxxxxxxxx. xxxx xxxxx xxxxx xxxx xx xx.xx. xxxxxx xxxxxxxxxxxx, xxxx xx xxx
xxxx xxxxxxxxxx xxxx xxx xxxxxxxx xxßxx, xxxxx xxx xxxxxx xxx xxxx xxx
xxxxxx xxxxx xxxx xx xxxxxxx xxxxxx "xxx xxx xxx xxxxxxx".

Note that line #2 has exactly 76 characters! So all correct.


Step #3 - we forward the message sent in step #2 inline to somebody else. It will be loaded into the editor this way:
---------------------------------------------------------------------------------------------------------------------

xxxäxxxx xxxxx xxx xxxxx xxxäxxxxx xxxxxx xxxxx xxxxxx xxxxxxxxxx
xxxxxxxxxx. xxxx xxxxx xxxxx xxxx xx xx.xx. xxxxxx xxxxxxxxxxxx, xxxx xx xxx
xxxx xxxxxxxxxx xxxx xxx xxxxxxxx xxßxx, xxxxx xxx xxxxxx xxx xxxx xxx
xxxxxx xxxxx xxxx xx xxxxxxx xxxxxx "xxx xxx xxx xxxxxxx".

So still all correct - at least it looks so.


Step #4 - we send the forwarded message, but now it will be re-wrapped like this:
---------------------------------------------------------------------------------

xxxäxxxx xxxxx xxx xxxxx xxxäxxxxx xxxxxx xxxxx xxxxxx xxxxxxxxxx
xxxxxxxxxx. xxxx xxxxx xxxxx xxxx xx xx.xx. xxxxxx xxxxxxxxxxxx, xxxx xx
xxx
xxxx xxxxxxxxxx xxxx xxx xxxxxxxx xxßxx, xxxxx xxx xxxxxx xxx xxxx xxx
xxxxxx xxxxx xxxx xx xxxxxxx xxxxxx "xxx xxx xxx xxxxxxx".

Look at lines #2 and #3. Now reproducable?


I believe this might be a simple counting problem: In step #2, RC is counting characters only and inserts an LF after pos. 76. In step #4, RC counts the already existing LF (which does not exist in step #2) as a character. This needs to be fixed, if my assumption should be correct. LFs shall not be counted as characters.

Reply highly appreciated.

Thanks and cheers,
--
Michael Heydekamp
Co-Admin freexp.de
Düsseldorf/Germany
_______________________________________________
Roundcube Users mailing list
us...@lists.roundcube.net
http://lists.roundcube.net/mailman/listinfo/users

--- End Message ---
_______________________________________________
Roundcube Development discussion mailing list
dev@lists.roundcube.net
http://lists.roundcube.net/mailman/listinfo/dev

Reply via email to