Hi guys, We are using roundcube at works and we found two problem we'd really like to see fixed.
The first one is trival: on/off french translation in sieve plugin are wrong telling filter is off when it's on and vice et versa. The second is a bit more tricky: the dovecot sieve vacation feature will act only the receive mail is addressed to exactly the user's mail. But the mail I use is not LOGIN@domain but first.lastname@domain making sieve never replying. The workaround is to add my address when enabling sieve filter. The patch I did will find my addresses from my roundcube identities and add them automatically. So our users has less things to do to make it works. I hope you'll find them usefull. Regards -- Olivier Thauvin CNRS - LATMOS ♖ ♘ ♗ ♕ ♔ ♗ ♘ ♖
commit 43c41f7772e7484cc48e118d922598da552d8d91 Author: Olivier Thauvin <[email protected]> Date: Mon Mar 16 18:15:09 2015 +0100 Add identities email to sieve vacation addresses This patch add identities email addresse into the :addresses vacation option allowing sieve to properly recognize email destination. diff --git a/plugins/managesieve/lib/Roundcube/rcube_sieve_vacation.php b/plugins/managesieve/lib/Roundcube/rcube_sieve_vacation.php index 8d86500..50ce839 100644 --- a/plugins/managesieve/lib/Roundcube/rcube_sieve_vacation.php +++ b/plugins/managesieve/lib/Roundcube/rcube_sieve_vacation.php @@ -329,6 +329,16 @@ class rcube_sieve_vacation extends rcube_sieve_engine 'noclose' => true ) + $attrib); + // Setting default identities into sieve vacation module + // This avoid issue when email is not login and sieve don't recognize it + if (!$this->vacation['addresses']) { + $identities = rcmail::get_instance()->user->list_identities(null, true); + $this->vacation['addresses'] = array(); + foreach ($identities as $idx => $ident) { + $this->vacation['addresses'][] = $ident['email_ascii']; + } + } + // form elements $subject = new html_inputfield(array('name' => 'vacation_subject', 'id' => 'vacation_subject', 'size' => 50)); $reason = new html_textarea(array('name' => 'vacation_reason', 'id' => 'vacation_reason', 'cols' => 60, 'rows' => 8));
commit 6f87c428f99d9388a9d0f828b4622beed45d7f1a Author: Olivier Thauvin <[email protected]> Date: Fri Mar 27 13:48:18 2015 +0100 Fix french translation (reverse on/off) diff --git a/plugins/managesieve/localization/fr_FR.inc b/plugins/managesieve/localization/fr_FR.inc index a0a38b0..51cc299 100644 --- a/plugins/managesieve/localization/fr_FR.inc +++ b/plugins/managesieve/localization/fr_FR.inc @@ -168,8 +168,8 @@ $labels['vacation.body'] = 'Corps'; $labels['vacation.start'] = 'Début de vacances'; $labels['vacation.end'] = 'Fin de vacances'; $labels['vacation.status'] = 'État'; -$labels['vacation.on'] = 'Arrêt'; -$labels['vacation.off'] = 'Marche'; +$labels['vacation.on'] = 'Marche'; +$labels['vacation.off'] = 'Arrêt'; $labels['vacation.addresses'] = 'Mes adresses supplémentaires'; $labels['vacation.interval'] = 'Plage de réponse'; $labels['vacation.after'] = 'Mettre en place la règle de vacances après';
pgpUhoa2dgwPU.pgp
Description: PGP signature
_______________________________________________ Roundcube Development discussion mailing list [email protected] http://lists.roundcube.net/mailman/listinfo/dev
