It is good. I use php 5.6. Obviously, in php the 7th this error is corrected.
Unfortunately,

I can't make the test about which you speak. I tried to make these corrections. But in my version of RC the place designated at you as lines 244-247 looks differently.


// return if encoding found, string matches encoding and convert succeeded if (in_array($mb_from, $mbstring_list) && in_array($mb_to, $mbstring_list)) {
                if (mb_check_encoding($str, $mb_from)) {
                    // Do the same as //IGNORE with iconv
                    mb_substitute_character('none');
                    $out = mb_convert_encoding($str, $mb_to, $mb_from);
                    mb_substitute_character($mbstring_sch);

                    if ($out !== false) {
                        return $out;
                    }
                }
            }
I don't decide to adapt your fix to my rcube_charset version.

---
Best regards,
   Vladimir Gorpenko

A.L.E.C писал 2016-09-27 18:07:
On 09/27/2016 02:04 PM, Vladimir Gorpenko wrote:
I can send an example of ISO-2022-KR which mbstring can't process.
I send it to your address the separate letter.

I commented iconv code path and wasn't able to reproduce the issue. I'm
using PHP7.

In case of GB2312, I suppose, there is nothing to investigate. Iconv
converts it normally, mbstring of such coding doesn't support, and with
renaming also converts absolutely normally.

Could you confirm that it works with
https://github.com/roundcube/roundcubemail/commit/42ddfe5ec9f0294bb3c44b6f7a9a0b205e951c45
instead of the previous patch?
_______________________________________________
Roundcube Development discussion mailing list
dev@lists.roundcube.net
http://lists.roundcube.net/mailman/listinfo/dev

Reply via email to