Hahaha it was me \o/
Seriously, I don't care about localization in test.
A long time ago we had a discussion about localization in tests.
I would have preferred to have some tests about localization mechanism
and no localization in the others.
The goal of all tests is *not* to check localization.
But the final decision was different.
In your commit you have mix localization and no localization, so I
update to full localization that's all.
Antoine
Le 14/06/2019 à 00:38, Samuel Gougeon a écrit :
Hello Clément,
Le 13/06/2019 à 15:02, Clément David a écrit :
Hello Samuel,
There should be no real difference, having ENGLISH IMPOSED might have
subtle bugs related to the
system locales whereas using gettext() will rely on an extra Scilab
function call (so will be less a
"unit test").
IMHO commits having only this kind of diff is useless; there should
be something else, could you
point us the related code-review ?
Both cases i had in mind were not commited just for this. But this
change was made in addition before merging.
Here is one case :
https://codereview.scilab.org/#/c/20723/6..7
There was another one around the 6.0.2 release, but i failed refinding
it.
I agree about the extra function call. But as i wrote before, i got
aware that using gettext() rather than ENGLISH IMPOSED is more robust
for (rare but possible) cases having a translation even for en_US.
Regards
Samuel
_______________________________________________
dev mailing list
dev@lists.scilab.org
http://lists.scilab.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@lists.scilab.org
http://lists.scilab.org/mailman/listinfo/dev
