On Mon, Jun 15, 2015 at 12:05:44PM -0700, Aaron Wolf wrote: > running hlint on Handler/SnowdriftEvent.hs has some weird errors, > several of this sort: > > ``` > Found: > getEventWikiEditR event_wiki_edit_id = undefined event_wiki_edit_id > Why not: > getEventWikiEditR = undefined > ``` > > Having a bunch of R get functions that are just undefined… is it okay to > do hlint's suggestions? shouldn't it just be a comma-separated list of > functions all just = undefined?
You could, because the definition would be identical. But... > Is the reason for the undefined that these resources somehow exist but > GET does nothing? Yes. > Are these functions somehow valuable otherwise? I doubt it? > Is passing an arg actually doing something, it would seem not. It's > just odd… maybe these are functions that *should* do more than they > currently do? Great question. If these functions are truly unused, as they appear to be, they should probably just be removed. Maybe they represent potential new features? If so, those features should be captured as tickets, and the stub code should be removed.
signature.asc
Description: Digital signature
_______________________________________________ Dev mailing list [email protected] https://lists.snowdrift.coop/mailman/listinfo/dev
