On Mon, Aug 03, 2015 at 11:14:01PM +0300, Nikita Karetnikov wrote: > I've got GitLab working (the same version that git.gnu.io uses) inside a > VM, so now I can finally reply. > > > Yes, that would be possible, but I think it would not meet the goal of > > automating the mechanical aspects of a code review. I think we want to > > test, then review, then merge, in that order. > > Okay, though, I think the other approach would be easier. Anyway, here > is a more detailed workflow: > > 1. Someone opens a merge request. > > 2. The merge request hook sends json to Bake: > > > https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/web_hooks/web_hooks.md#merge-request-events > > (The URI can be provided in the GitLab UI.) > > The "state" attribute must be set to "opened" in this case. (The > other ones are "reopened" and "closed".) > > 3. Bake uses the "object_attributes" fields to fetch the source > branch. > > 4. Bake runs the tests. > > (Question: should Bake test after merging the source to target or > not?)
It should test after the merge, and report merge failures as well as test failures. > 5. Bake posts a report to a merge request using the API: > > http://doc.gitlab.com/ce/api/merge_requests.html#post-comment-to-mr > > It's not clear how to use web hooks to trigger Bake when someone > pushes to a branch that's already associated with a merge request. No message is sent in that case? :( The docs specifically say that the merge request event is "triggered when a new merge request is created, an existing merge request was updated/merged/closed or a commit is added in the source branch." Are the docs wrong? > Folks would definitely want to correct things (that's the point of > having a review process after all). Precisely. > We could probably work around that by using the "comment on merge > request" hook. Something like: "Bake it!" But I don't really like this > solution since it's error-prone. Definitely.
signature.asc
Description: Digital signature
_______________________________________________ Dev mailing list [email protected] https://lists.snowdrift.coop/mailman/listinfo/dev
