I meant to follow up earlier, but for the record I couldn't figure how to apply these changes to the tests. From what I remember his speedups came from flushing and closing stdin, while we never even create a handle for stdin in withExecutable. We also don't wait for all of stdout, we just kill the process as soon as we get what we want, so I don't think waitForProcess would help us. I experimented with these things and couldn't get any speedup, but I don't understand the underlying problems that Gabriel fixed to say for sure I was doing solved the problems he had.
On Tue, Aug 4, 2015, at 08:36 AM, Curtis Gagliardi wrote: > I'll give it a shot. I tried to speed them up by parallelizing them the > other day (hspec includes a parallel test runner), but unfortunately it > breaks everything with a generic "exception occurred here" message. > > On Mon, Aug 3, 2015, at 05:25 PM, Bryan Richter wrote: > > I have a suspicion we might speed up tests with "this one trick". From > > Gabriel Gonzalez on twitter: "I finally fixed the silly delays running > > external commands..." > > > > His original tweet (with some discussion): > > https://twitter.com/GabrielG439/status/624405459370311681 > > > > His inspiration: > > http://lpaste.net/136737 > > > > The change he made to turtle: > > https://github.com/Gabriel439/Haskell-Turtle-Library/commit/4f907f177a0fe174e97ee09711d95f015a2346cf > > > > We might want to make a similar change to `withExecutable` in > > tests/TestImport.hs. Someone want to try it? > > _______________________________________________ > > Dev mailing list > > [email protected] > > https://lists.snowdrift.coop/mailman/listinfo/dev > > Email had 1 attachment: > > + signature.asc > > 1k (application/pgp-signature) _______________________________________________ Dev mailing list [email protected] https://lists.snowdrift.coop/mailman/listinfo/dev
