Hi Thomas, > * the helpful debug output for a),
Applied, [1]. > * an additional printf_hook addressing b), I'm a little sceptic about introducing printf_hooks for such less generic objects. The hook works fine for logging to console, but does not help much if you want to display it to other mediums (web interface, GUI, whatever). So I'd prefer some getters for queued tasks, and do the formatting in the stroke plugin itself. I pushed some patches to provide such an API [2], [3] ... > * some optimization for the use of the newly introduced hook in > stroke_list, > * the actual use of the hook in stroke_list, and last but not least ... and print it in stroke [4]. > * my proposal for a solution of the problem mentioned above Your approach looks fine to me. I'd prefer to keep the task creation outside of the task_manager [5], but this is purely a matter of taste. The ike_sa_t.reset() function was not really complete for this post-ike_init case, patch [6] resets some additional state. [7] is required to properly make use of this state. Many thanks for your valuable patches, Thomas! Best regards Martin [1]http://git.strongswan.org/?p=strongswan.git;a=commitdiff;h=03ffa88531c33005bd60ba733b4f5a8f581d530f [2]http://git.strongswan.org/?p=strongswan.git;a=commitdiff;h=665c18bd85b2157e2635219edb80d987aa95a8a8 [3]http://git.strongswan.org/?p=strongswan.git;a=commitdiff;h=ea340ee8400826c0204eb88dc452248bde227c52 [4]http://git.strongswan.org/?p=strongswan.git;a=commitdiff;h=a3ffa9edfdb9cf2215f554e4ce75e813799b906a [5]http://git.strongswan.org/?p=strongswan.git;a=commitdiff;h=dbdb69f908c9ba2b61011fa5f70b948a8b2ae0cd [6]http://git.strongswan.org/?p=strongswan.git;a=commitdiff;h=550d9085fae07a2a7e8762e2d6057957860ec893 [7]http://git.strongswan.org/?p=strongswan.git;a=commitdiff;h=8b56ec20f365f8f9d8ea4174eaa88c86dc5687e8 _______________________________________________ Dev mailing list [email protected] https://lists.strongswan.org/mailman/listinfo/dev
