This won't hurt as long as sets and validators are of the same class.
But as soon as one of the object's class is changed this will cause
either a compile error (best option), or result (most likely) in a
crash.

Signed-off-by: Thomas Egerer <[email protected]>
---
Hello *,

I guess I found a copy and paste error in the credential manager code.
It is not critical, in fact it does not have any effect at all, but
I think it is worth fixing.

Cheers, Thomas

 src/libstrongswan/credentials/credential_manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/src/libstrongswan/credentials/credential_manager.c b/src/libstrongswan/credentials/credential_manager.c
index 3ec0714..b0c8e48 100644
--- a/src/libstrongswan/credentials/credential_manager.c
+++ b/src/libstrongswan/credentials/credential_manager.c
@@ -1279,7 +1279,7 @@ METHOD(credential_manager_t, add_validator, void,
 	private_credential_manager_t *this, cert_validator_t *vdtr)
 {
 	this->lock->write_lock(this->lock);
-	this->sets->insert_last(this->validators, vdtr);
+	this->validators->insert_last(this->validators, vdtr);
 	this->lock->unlock(this->lock);
 }
 

_______________________________________________
Dev mailing list
[email protected]
https://lists.strongswan.org/mailman/listinfo/dev

Reply via email to