Hi Tobias,

On 02/21/18 11:58, Tobias Brunner wrote:
Hi Harri,

Do I have to upgrade n-m-s to version 1.4.3 for Strongswan 5.6.2?

I don't think so.  But the backend was migrated from libnm-glib to libnm
which required changes in how the data is passed to NM (see [1] for the
commit).  Could be that something went wrong there.  For instance, it
may not actually be necessary to call g_variant_new_unint32() on line 69
in nm_service.c.  It might just be enough to pass the value.  Could you
try the patch in the nm-dns-fix branch.


Yup, thats it. After including your patch into strongswan 5.6.2
/etc/resolv.conf is setup correctly (still using NM applet 1.4.2).


Thanx very much
Harri
diff --git a/src/charon-nm/nm/nm_service.c b/src/charon-nm/nm/nm_service.c
index 9beac392a..c42733181 100644
--- a/src/charon-nm/nm/nm_service.c
+++ b/src/charon-nm/nm/nm_service.c
@@ -65,8 +65,7 @@ static GVariant* handler_to_variant(nm_handler_t *handler,
 	enumerator = handler->create_enumerator(handler, type);
 	while (enumerator->enumerate(enumerator, &chunk))
 	{
-		g_variant_builder_add (&builder, "u",
-							   g_variant_new_uint32 (*(uint32_t*)chunk.ptr));
+		g_variant_builder_add (&builder, "u", *(uint32_t*)chunk.ptr);
 	}
 	enumerator->destroy(enumerator);
 

Reply via email to