Yes, it looks good now.

You can also add a link to the gerrit homepage:

https://code.google.com/p/gerrit/

The direct link to the gerrit documentation contains a version number, so it should not be added (because it will go out of date quickly):

https://gerrit-documentation.storage.googleapis.com/Documentation/2.8.1/index.html

Alex


On 02/27/2014 06:19 AM, Lv, RuiX wrote:
Hi All,

Thanks a lot for your opinions.
We appreciate your feedback towards our documentation very much.

We've updated the corresponding document, as shown below, after absorbing 
opinions from all of you.
https://source.tizen.org/documentation/developer-guide/submitting-and-reviewing-on-gerrit-and-obs

Hope the new version could eliminate all possible confusion and misleading.
If any questions, please feel free to raise it.

Thanks
Rui

-----Original Message-----
From: [email protected] [mailto:[email protected]] On 
Behalf Of Thiago Macieira
Sent: Thursday, February 27, 2014 12:47 AM
To: [email protected]
Subject: Re: [Dev] How to set up gerrit? The instructions are NOT helpful

Em qua 26 fev 2014, às 16:04:53, Kanevskiy, Alexander escreveu:
Let me explain few additions that might be useful:

1. in remote “origin” section:

     push = HEAD:refs/for/devel

this helps to simplify operation with submitting patches.

without it, it’s better to do “git push origin HEAD:refs/for/tizen”
(if you’re submitting patches from your HEAD towards tizen branch for review).
line above just makes it simpler for developer to type “git push origin”.
the rest, HEAD and target branch it would take from config.


2. in remote “origin” section:
     receivepack = git receive-pack --reviewer=<E-mail_Address> …


this helps to add automatically some specific reviewers for that
project, if you’d like to specify them manually. (e.g. you want 2-3 of
your colleagues explicitly reviewing your patches).
You don’t need to do that explicitly, as domain maintainers would
would be added automatically to change.

Hint: use the git-gpush script that you can find here:

        https://qt.gitorious.org/qt/qtrepotools/source/master:bin/git-gpush

You just need to make sure that the gerrit remote is called "gerrit". If you 
cloned from Gerrit, you can do:

        git remote rename origin gerrit

Then you can do:

        git gpush :devel
        git gpush :devel [email protected]           # adds as reviewer
        git gpush :devel [email protected]           # adds as Cc
        git gpush SHA-1:devel                           # pushes SHA-1 instead 
of HEAD

Instead of email addresses, you can also use Gerrit account names.
--
Thiago Macieira - thiago.macieira (AT) intel.com
   Software Architect - Intel Open Source Technology Center

_______________________________________________
Dev mailing list
[email protected]
https://lists.tizen.org/listinfo/dev
_______________________________________________
Dev mailing list
[email protected]
https://lists.tizen.org/listinfo/dev


_______________________________________________
Dev mailing list
[email protected]
https://lists.tizen.org/listinfo/dev

Reply via email to