I could do this quietly... but I'm choosing not to for maximum effect: Seriosuly:
https://review.tizen.org/gerrit/#/c/61462/11 "Let's remove 700,000 lines of code or so just because we like to". So this is a git repo based on an upstream project. I have worked on Tizen and SLP before that and X1 before that... and I have watched for years as people just do not understand the cost of forking and technical debt, and then watched the incredible pain as 1, 2 or 3 years later that wall of pain is hit... and here I see it again. That has to be one of the WORST commit log mesages I have ever seen. A commit that removes 700k of code and just has a log of: "Clean up the enlightenment wayland display server" What on earth? That is the entire commit log with a change that big? Where is the reasoning. Justification? Measurements? Some log detailing the weighing up of pros and cons and the discussion related to that? Nothing there. Seriously. This is not just a bad idea, but it's unprofessional in the extreme in the way this has been done. ... But as there is no log reasoning as to why, I'll just launch into speculation instead, because hey, the door has been opened so give no information, let people make up whatever they like instead. It's much more fun this way. The above commit smells to me of "Oh well we just couldn't care less about technical debt and the price we have to pay in future, so we have zero interest in working with upstream, and will just fork off into our own world because that's all we know". You never intend to sync with upstream code ever again do you? That's exactly what this commit screams to me. You just want to make your own world? Open source community be damned. In fact your own cost of being able to merge in fixes or changes or improvements just skyrocketed through the roof. You do not care about the technical debt you just created because of a "clean up of 700k lines". That is what this commit screams to me just at a glance. I actually know what the vast majority of those 700k lines of change do. Do you? Do you know the value you just threw out and the costs you created? What is the value in removing code that doesn't even get compiled (optional modules)? All it does is create more conflicts when merging. Not to mention, what is the value of removing all the code that makes Tizen a working desktop UI? Just because you don't use it right now does not mean it will not be used? You do know we had a Tizen PC profile before? How short sighted does such a commit really need to be? What do you do when someone wants to make thin clients with Tizen? Netbooks? You just threw out the code. You just made it nigh impossible to sync code with upstream... for what gain or value? Save some RAM? How much? Did you even measure or benchmark? I see nothnig in a commit log to justify this. Likely not that much is saved as unused code wont be executed thus loaded into RAM and most of it isn't even compiled or packaged and installed. What was saved? A few hundred Kb total on a whole system? Save some disk space? How much? Is it worth it? There is (mostly) no such thing as a free lunch. Every "saving" often comes at a cost. What cost? is it worth it? Nothing here to explain, justify etc. nor any discussion about this anywhere. I can go on, but this has to be one of the single poorest commit messages I have ever seen when combined with the sheer amount of code it touched (either modified or removed). _______________________________________________ Dev mailing list Dev@lists.tizen.org https://lists.tizen.org/listinfo/dev
