Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/incubator-livy/pull/113#discussion_r221750636
  
    --- Diff: thriftserver/client/pom.xml ---
    @@ -0,0 +1,66 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +  ~ Licensed to the Apache Software Foundation (ASF) under one or more
    +  ~ contributor license agreements.  See the NOTICE file distributed with
    +  ~ this work for additional information regarding copyright ownership.
    +  ~ The ASF licenses this file to You under the Apache License, Version 2.0
    +  ~ (the "License"); you may not use this file except in compliance with
    +  ~ the License.  You may obtain a copy of the License at
    +  ~
    +  ~    http://www.apache.org/licenses/LICENSE-2.0
    +  ~
    +  ~ Unless required by applicable law or agreed to in writing, software
    +  ~ distributed under the License is distributed on an "AS IS" BASIS,
    +  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    +  ~ See the License for the specific language governing permissions and
    +  ~ limitations under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0";
    +         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +  <parent>
    +    <artifactId>livy-main</artifactId>
    +    <groupId>org.apache.livy</groupId>
    +    <version>0.6.0-incubating-SNAPSHOT</version>
    +  </parent>
    +  <modelVersion>4.0.0</modelVersion>
    +
    +  <artifactId>livy-beeline</artifactId>
    +
    +  <dependencies>
    +    <dependency>
    +      <groupId>org.apache.hive</groupId>
    +      <artifactId>hive-jdbc</artifactId>
    +      <version>${hive.version}</version>
    +    </dependency>
    +    <dependency>
    +      <groupId>org.apache.hive</groupId>
    +      <artifactId>hive-beeline</artifactId>
    +      <version>${hive.version}</version>
    +    </dependency>
    +  </dependencies>
    +  <build>
    +    <plugins>
    +      <plugin>
    +        <groupId>org.apache.maven.plugins</groupId>
    +        <artifactId>maven-dependency-plugin</artifactId>
    +        <executions>
    +          <execution>
    +            <phase>package</phase>
    +            <goals>
    +              <goal>copy-dependencies</goal>
    +            </goals>
    +          </execution>
    +        </executions>
    +      </plugin>
    +
    +      <plugin>
    +        <groupId>org.apache.maven.plugins</groupId>
    +        <artifactId>maven-jar-plugin</artifactId>
    --- End diff --
    
    There's no code here, right? Shouldn't the pom's packaging be just "pom" 
instead of the default ("jar")? Or does that mess up the dependency plugin?


---

Reply via email to