[GitHub] incubator-livy pull request #114: [LIVY-495] Add thriftserver UI

[vanzin]

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/incubator-livy/pull/114#discussion_r221752067
  
    --- Diff: 
server/src/main/scala/org/apache/livy/server/ThriftServerFactory.scala ---
    @@ -30,6 +32,8 @@ trait ThriftServerFactory {
         livySessionManager: InteractiveSessionManager,
         sessionStore: SessionStore,
         accessManager: AccessManager): Unit
    +
    +  def getUI(basePath: String): ScalatraServlet
    --- End diff --
    
    Does it need to explicitly return a `ScalatraServlet` instead of a more 
generic type?


---