Github user mgaido91 commented on the issue:

    https://github.com/apache/incubator-livy/pull/117
  
    thanks for the review @vanzin. I have updated the PR description. Let me 
know if it still needs to be improved.
    
    >  I think as a first step getting the Hive code in, with the minimal 
amount of changes necessary, is better.
    
    I am not sure, as the only difference from that was moving from Java to 
Scala, which saves many conversion back and forth of collections and hence adds 
unneeded code only to handle this.
    
    > overall take another look at whether the things you're forking really 
need to be forked
    
    I am pretty sure that nothing which is there is unneeded.



---

Reply via email to