Github user ajbozarth commented on a diff in the pull request:

    https://github.com/apache/incubator-livy/pull/114#discussion_r223523441
  
    --- Diff: 
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/ui/ThriftUIServlet.scala
 ---
    @@ -0,0 +1,84 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.livy.thriftserver.ui
    +
    +import java.text.SimpleDateFormat
    +
    +import scala.collection.JavaConverters._
    +import scala.xml.Node
    +
    +import org.json4s.{DefaultFormats, Formats}
    +import org.scalatra.json._
    +
    +import org.apache.livy.server.ui.BaseServlet
    +import org.apache.livy.thriftserver.LivyThriftServer
    +
    +class ThriftUIServlet(val basePath: String) extends BaseServlet with 
JacksonJsonSupport {
    +
    +  protected implicit val jsonFormats: Formats = DefaultFormats
    +
    +  private val df = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss")
    +
    +  private case class ThriftSessionsPage(name: String = "JDBC Sessions") 
extends Page {
    +    override def getNavTabs: Seq[Node] = {
    --- End diff --
    
    yeah when originally designing the UI I went back and forth a lot trying to 
get the L&F right and ended up using a tabbed looked even through they were 
breadcrumbs. Actually on that thought I have an idea. I'll type it up as a full 
comment below


---

Reply via email to