I am seeing several issues on the thriftserver, anyway , since it is kind of a preview of the thriftserver, probably this is not a big deal. The major one is https://issues.apache.org/jira/browse/LIVY-572, which can be workarounded with a config, though. The SHA is ok, and the files in the distributions are too. Since we already said that thriftserver issues are not a reason good enough for failing this RC vote, I am +1 on this. Thanks Marcelo!
Il giorno mer 20 mar 2019 alle ore 18:25 Marco Gaido <[email protected]> ha scritto: > Agree on not failing for Thriftserver issues, just wondering if we are > doing something wrong when generating the JARs. > > Il giorno mer 20 mar 2019 alle ore 18:10 Marcelo Vanzin > <[email protected]> ha scritto: > >> Hi, >> >> Sorry, but as I mentioned in the other thread, I haven't used Livy in >> a while and I don't really have time to investigate things past the >> existing tests. Anyone is free to do it, though. >> >> I'd rather not fail a release because of a problem in the thrift >> server; it's new and "experimental", so I'd expect issues. >> >> On Wed, Mar 20, 2019 at 2:07 AM Marco Gaido <[email protected]> >> wrote: >> > >> > Hi Marcelo, >> > >> > thanks for starting the vote. I tried downloading the zip and enabling >> the >> > thriftserver, but connecting with beeline and running a query throws an >> > exception to me: >> > >> > 0: jdbc:hive2://localhost:10090/> create table foo as select a.* from >> > (select 1, "2") a; >> > >> > Error: java.lang.RuntimeException: java.util.NoSuchElementException: >> > Statement ce95f6bb-bf51-4fca-b61d-0d40272b3a33 not found in session >> > 774fed7a-8388-43fd-978f-8d2bd31c4a12. >> > >> > >> org.apache.livy.thriftserver.session.ThriftSessionState.statementNotFound(ThriftSessionState.java:118) >> > >> > >> org.apache.livy.thriftserver.session.ThriftSessionState.cleanupStatement(ThriftSessionState.java:107) >> > >> > >> > This may also be caused by some problems in my local environment though, >> > since the tests on Travis are passing. May someone else try if they face >> > the same issue anyway? In the config I just enabled the thriftserver >> with >> > the proper config. >> > Thanks, >> > Marco >> > >> > Il giorno mar 19 mar 2019 alle ore 22:58 Marcelo Vanzin >> > <[email protected]> ha scritto: >> > >> > > Err. Should have read "based on RC2". Too fast on the send button! >> > > >> > > Anyway, here's my +1. >> > > >> > > Note this build does includes the pre-compiled jars for the thrift >> server. >> > > >> > > On Tue, Mar 19, 2019 at 2:56 PM Marcelo Vanzin <[email protected]> >> > > wrote: >> > > > >> > > > This vote is for releasing Livy 0.6.0 based on RC2. >> > > > >> > > > The vote will be open at least 72 hours until Friday March 21st, >> 22:00 >> > > UTC and >> > > > will pass with a minimum of 3 +1 binding votes and a majority of >> > > positive votes. >> > > > >> > > > [+1] This release is ready to send to the Incubator PMC for approval >> > > > >> > > > [-1] This release is not ready because... >> > > > >> > > > This vote is held according to Apache Incubator release policy: >> > > > https://incubator.apache.org/policy/incubation.html#releases >> > > > >> > > > The RC is based on tag v0.6.0-incubating-rc2: >> > > > https://github.com/apache/incubator-livy/commit/28be98cabc >> > > > >> > > > The release files can be found here: >> > > > >> > > >> https://dist.apache.org/repos/dist/dev/incubator/livy/0.6.0-incubating-rc2/ >> > > > >> > > > The staged maven artifacts can be found here: >> > > > >> https://repository.apache.org/content/repositories/orgapachelivy-1008 >> > > > >> > > > The list of resolved JIRAs in this release can be found here: >> > > > https://issues.apache.org/jira/projects/LIVY/versions/12342736 >> > > > >> > > > >> > > > -- >> > > > Marcelo >> > > >> > > >> > > >> > > -- >> > > Marcelo >> > > >> >> >> >> -- >> Marcelo >> >
