I think this should go into a new maven module "log4j-redis" since it has a specific external dependency (Jedis).
We will most likely split up the NoSQL module and we don't want to add anything new to it. "NoSQL" is not really a useful abstraction within the context of Log4j. On Sat, May 6, 2017 at 10:00 PM, Matt Sicker <[email protected]> wrote: > Yeah, as mentioned on the ticket, we're working on splitting up that module > as it is. > > On 6 May 2017 at 15:00, Gary Gregory <[email protected]> wrote: > > > On Sat, May 6, 2017 at 12:48 PM, Volkan Yazıcı <[email protected]> > > wrote: > > > > > I was thinking of log4j-nosql Maven module. > > > Cassandra, CouchDb, MongoDb appenders also exist within the same Maven > > > module. > > > Are you sure that I need to create a separate Maven module just for the > > > Redis appender? > > > > > > > Let's see what others think. It seems that moving forward we only want to > > have Maven modules that have required dependencies as much as possible > for > > just the one feature. As opposed to kitchen sink modules that drag in > > dependencies for all features, whether the user wants them or not. > > > > Gary > > > > > > > On Sat, May 6, 2017 at 9:40 PM, Gary Gregory <[email protected]> > > > wrote: > > > > > > > Hi Volkan, > > > > > > > > Thank you for contributing to Log4j. > > > > > > > > This should do in a new Maven module IMO. > > > > > > > > Gary > > > > > > > > On Sat, May 6, 2017 at 11:30 AM, Volkan Yazıcı < > > [email protected]> > > > > wrote: > > > > > > > > > Hello, > > > > > > > > > > To the best of my knowledge, there is no Redis support in Log4j 2.x > > > NoSQL > > > > > Appenders. (Please correct if I'm wrong.) I want to create a JIRA > > > ticket > > > > > and start working on a RedisAppender. Though I do have some > questions > > > and > > > > > will appreciate your feedback. > > > > > > > > > > 1. I plan to use Jedis <https://github.com/xetorthio/jedis> for > > > > client > > > > > and perform no shading/relocation. Objections? > > > > > 2. I want to introduce throttling via Guava's RateLimiter. Is > that > > > ok? > > > > > 3. I am thinking of a background worker Thread periodically > > polling > > > an > > > > > ArrayBlockingQueue with a fixed size. This will help me to > > > facilitate > > > > > the > > > > > following features: > > > > > 1. Queue will act as a buffer addressing temporary > > > produce-consume > > > > > rate mismatch. > > > > > 2. Background thread will create batches out of the queue, > > rather > > > > > than individual inserts. > > > > > 3. Periodic polling will ensure that we avoid starvation when > > not > > > > > enough messages for a batch. > > > > > 4. I will allow comma separated multiple <host>:<port> pairs to > > > allow > > > > > fail-over. That is, I will create a Jedis client for each > > > > <host>:<port> > > > > > pair and try them in given order in case of a failure. > > > > > > > > > > I'm planning to make a pitch on Monday to have some *company time* > > for > > > > this > > > > > story. So please do let me know of what you think. > > > > > > > > > > Best. > > > > > > > > > > > > > > > > > > > > > -- > > > > E-Mail: [email protected] | [email protected] > > > > Java Persistence with Hibernate, Second Edition > > > > <https://www.amazon.com/gp/product/1617290459/ref=as_li_ > > > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459& > > > > linkCode=as2&tag=garygregory-20&linkId= > cadb800f39946ec62ea2b1af9fe6a2 > > b8> > > > > > > > > <http:////ir-na.amazon-adsystem.com/e/ir?t= > garygregory-20&l=am2&o=1&a= > > > > 1617290459> > > > > JUnit in Action, Second Edition > > > > <https://www.amazon.com/gp/product/1935182021/ref=as_li_ > > > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021& > > > > linkCode=as2&tag=garygregory-20&linkId= > 31ecd1f6b6d1eaf8886ac902a24de4 > > > 18%22 > > > > > > > > > > > > > <http:////ir-na.amazon-adsystem.com/e/ir?t= > garygregory-20&l=am2&o=1&a= > > > > 1935182021> > > > > Spring Batch in Action > > > > <https://www.amazon.com/gp/product/1935182951/ref=as_li_ > > > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951& > > > > linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B% > > > > 7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> > > > > <http:////ir-na.amazon-adsystem.com/e/ir?t= > garygregory-20&l=am2&o=1&a= > > > > 1935182951> > > > > Blog: http://garygregory.wordpress.com > > > > Home: http://garygregory.com/ > > > > Tweet! http://twitter.com/GaryGregory > > > > > > > > > > > > > > > -- > > E-Mail: [email protected] | [email protected] > > Java Persistence with Hibernate, Second Edition > > <https://www.amazon.com/gp/product/1617290459/ref=as_li_ > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459& > > linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> > > > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a= > > 1617290459> > > JUnit in Action, Second Edition > > <https://www.amazon.com/gp/product/1935182021/ref=as_li_ > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021& > > linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de4 > 18%22 > > > > > > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a= > > 1935182021> > > Spring Batch in Action > > <https://www.amazon.com/gp/product/1935182951/ref=as_li_ > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951& > > linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B% > > 7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a= > > 1935182951> > > Blog: http://garygregory.wordpress.com > > Home: http://garygregory.com/ > > Tweet! http://twitter.com/GaryGregory > > > > > > -- > Matt Sicker <[email protected]> > -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* [email protected] Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magine.com Privileged and/or Confidential Information may be contained in this message. If you are not the addressee indicated in this message (or responsible for delivery of the message to such a person), you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email.
