[ 
https://issues.apache.org/jira/browse/LOG4NET-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018011#comment-16018011
 ] 

Dominik Psenner edited comment on LOG4NET-565 at 5/19/17 9:18 PM:
------------------------------------------------------------------

You'll have to clone the repository on github to have a place where you can do 
your changes. You should probably also fork the project to have a place to 
publish your changes. Then you could create a named branch feature/LOG4NET-565 
that branches from the latest head and commit your changes. We can then review 
those changes on the fork or you open a pull request and we review the changes 
in the pull request.

Please note that I did something similar a few moments ago for the named branch 
feature/RollingFileAppender-NG 
(https://github.com/apache/logging-log4net/compare/feature/RollingFileAppender-NG).
 However, this operation differs in that I have the karma to push changes to 
the apache repository.


was (Author: nachbarslumpi):
You'll have to clone the repository on github to have a place where you can 
publish your changes. Then you could create a named branch feature/LOG4NET-565 
that branches from the latest head and commit your changes. We can then review 
those changes on the clone or within the pull request.

Please note that I did something similar a few moments ago for the named branch 
feature/RollingFileAppender-NG 
(https://github.com/apache/logging-log4net/compare/feature/RollingFileAppender-NG).
 However, this operation differs in that I have the karma to push changes to 
the apache repository.

> Dependency Injection support appender and logger types
> ------------------------------------------------------
>
>                 Key: LOG4NET-565
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-565
>             Project: Log4net
>          Issue Type: Improvement
>          Components: Appenders, Core
>            Reporter: Hitesh Chauhan
>              Labels: Enhancement
>
> I have seen demand for dependency injection support in log4net. I have added 
> that behavior to my local repository. And I would like to push that to 
> log4net library.
> e.g. appender configuration
> <appender
> name="ServiceAppender" 
> type="LoggingServiceAppender"               
> serviceLocatorType="Log4NetServiceLocator">



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to