[ 
https://issues.apache.org/jira/browse/LOG4J2-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021309#comment-16021309
 ] 

Matt Sicker commented on LOG4J2-1442:
-------------------------------------

Some other code review comments:

* Can use try-with-resources here: 
https://github.com/apache/logging-log4j2/blob/master/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/HttpURLConnectionManager.java#L109
* This 
[connection|https://github.com/apache/logging-log4j2/blob/master/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/HttpURLConnectionManager.java#L80]
 should probably be cached. This allows for the connection to be reused which 
seems like a useful scenario for higher frequency logging.
* A feature request here may be to support batched log messages, but that would 
require more advanced configuration most likely.

> Add generic HTTP verb appender
> ------------------------------
>
>                 Key: LOG4J2-1442
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1442
>             Project: Log4j 2
>          Issue Type: New Feature
>          Components: Appenders
>            Reporter: Matt Sicker
>            Assignee: Mikael Ståldal
>             Fix For: 2.9
>
>
> Inspired by [this mailing list 
> post|http://apache-logging.6191.n7.nabble.com/Custom-appender-needed-to-HTTP-POST-log-msgs-td52921.html].
>  This would in one swoop support various APIs such as:
> * Slack and other ChatOps software
> * ElasticSearch
> * ...I'm sure there's more
> Basic features that would be needed are:
> * HTTP verb
> * headers
> * body



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to