Pull requests are definitely easier to merge, plus you get a nicer online diff tool that way. Patch files are fine, too, but only if you prefer submitting them that way.
On 22 June 2017 at 10:53, Gary Gregory <[email protected]> wrote: > It is really up to you, what ever works for you. > > Gary > > On Jun 22, 2017 03:38, "Pierrick HYMBERT" <[email protected]> > wrote: > > > Hi, > > > > What is the most appropriate way for log4j team to handle external > > contribution ? GitHub Pull Request or Patch file ? > > > > I used to attach patch in jira from my local branch, but then I tried > > tutorial from Gary [1] and see that it is possible to ask for PR directly > > from github forked repo [2] and then you may merge to apache repo. > > > > Personnaly I feel it more convenient, don't you ? > > > > [1] > > https://garygregory.wordpress.com/2016/11/10/how-to-catch- > > up-my-git-fork-to-master/ > > [2] https://github.com/phymbert/logging-log4j2 > > > -- Matt Sicker <[email protected]>
