[
https://issues.apache.org/jira/browse/LOG4J2-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080637#comment-16080637
]
ASF GitHub Bot commented on LOG4J2-1864:
----------------------------------------
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/62#discussion_r126476697
--- Diff:
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/mongodb/MongoDbProvider.java
---
@@ -21,50 +21,60 @@
import java.util.ArrayList;
import java.util.List;
-import com.mongodb.DB;
-import com.mongodb.MongoClient;
-import com.mongodb.MongoCredential;
-import com.mongodb.ServerAddress;
-import com.mongodb.WriteConcern;
import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.core.Core;
import org.apache.logging.log4j.core.config.plugins.Plugin;
-import org.apache.logging.log4j.core.config.plugins.PluginAttribute;
+import org.apache.logging.log4j.core.config.plugins.PluginBuilderAttribute;
+import org.apache.logging.log4j.core.config.plugins.PluginBuilderFactory;
import org.apache.logging.log4j.core.config.plugins.PluginFactory;
import org.apache.logging.log4j.core.config.plugins.convert.TypeConverters;
+import
org.apache.logging.log4j.core.config.plugins.validation.constraints.Required;
import
org.apache.logging.log4j.core.config.plugins.validation.constraints.ValidHost;
import
org.apache.logging.log4j.core.config.plugins.validation.constraints.ValidPort;
+import org.apache.logging.log4j.core.filter.AbstractFilterable;
import org.apache.logging.log4j.core.util.NameUtil;
import org.apache.logging.log4j.nosql.appender.NoSqlProvider;
import org.apache.logging.log4j.status.StatusLogger;
import org.apache.logging.log4j.util.LoaderUtil;
import org.apache.logging.log4j.util.Strings;
+import com.mongodb.DB;
+import com.mongodb.MongoClient;
+import com.mongodb.MongoCredential;
+import com.mongodb.ServerAddress;
+import com.mongodb.WriteConcern;
+
/**
* The MongoDB implementation of {@link NoSqlProvider}.
*/
-@Plugin(name = "MongoDb", category = "Core", printObject = true)
+@Plugin(name = "MongoDb", category = Core.CATEGORY_NAME, printObject =
true)
public final class MongoDbProvider implements
NoSqlProvider<MongoDbConnection> {
private static final WriteConcern DEFAULT_WRITE_CONCERN =
WriteConcern.ACKNOWLEDGED;
private static final Logger LOGGER = StatusLogger.getLogger();
private static final int DEFAULT_PORT = 27017;
+ private static final int DEFAULT_COLLECTION_SIZE = 536870912;
--- End diff --
Magic number?
> Support capped collection for MongoDB Log-Provider
> --------------------------------------------------
>
> Key: LOG4J2-1864
> URL: https://issues.apache.org/jira/browse/LOG4J2-1864
> Project: Log4j 2
> Issue Type: New Feature
> Components: Appenders
> Reporter: Matt
>
> MongoDB supports sth. called capped collections. If the
> nosql-mongodb-appender supports this feature, the mongodb-collection could
> never "overflow" and stick to a defined maximum size.
> see [pull request 62|https://github.com/apache/logging-log4j2/pull/62] for
> more details.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
