Hi, You should do atomar modifications in single commits and file one pull request for a sensible set of patches. Remember to also write sensible commit messages that explain what is done and why it is done. This allows easy and fast code reviews. Github is great for doing all but the actual coding.
Cheers On 19 Jul 2017 1:47 p.m., "João Paulo Lemes Machado" <[email protected]> wrote: > Hello everyone. > > My name is João Paulo, I am a graduate student the Federal University of > Uberlandia, Brazil. > > I was analyzing the modularization of some classes of log4j, and I > identified some opportunities for cohesion improvement in the following > classes: > > Logger > DefaultConfigurationBuilder > ConfigurationBuilder > MutableLogEvent > AbstractConfiguration > Log4jLogEvent > RingBufferLogEven > > Could you please take a look and tell me if it's viable? > > Maybe some of these classes could benefit from some kind of refactoring > that we can discuss. >
