I think that would be too expensive to do on each event.

Note that there are three levels: addDocument(), flush(), and commit(). I
could see that how often to flush and or commit should be configurable.
Either every N events, or every N TimeUnits.

Gary

On Mon, Jul 24, 2017 at 9:04 PM, kenneth mcfarland <
[email protected]> wrote:

> Ok I'm blind but maybe can add a commit() after line 193 right after
> addDocument() to be aggressive
>
> On Jul 24, 2017 8:54 PM, "garydgregory" <[email protected]> wrote:
>
> > Github user garydgregory commented on the issue:
> >
> >     https://github.com/apache/logging-log4j2/pull/82
> >
> >     Is what is happening
> >     in org.apache.logging.log4j.lucene5.appender.
> LuceneAppender.stop(long,
> >     TimeUnit) not good enough?
> >
> >     Gary
> >
> >     On Mon, Jul 24, 2017 at 8:30 PM, asfbot <[email protected]>
> > wrote:
> >
> >     > kenneth mcfarland on [email protected] replies:
> >     > Why don't you call close() or commit() on the indexwriter? If
> log4j2
> > is
> >     > serious about being an auditing platform some attention to flushing
> > and
> >     > such should be addressed. Note I am not an expert but I believe I
> am
> >     > somewhere in the ballpark.
> >     >
> >     > —
> >     > You are receiving this because you commented.
> >     > Reply to this email directly, view it on GitHub
> >     > <https://github.com/apache/logging-log4j2/pull/82#
> > issuecomment-317618689>,
> >     > or mute the thread
> >     > <https://github.com/notifications/unsubscribe-auth/ABIfN6D_
> > jsLHaJif7ngIlu4q1HLTGYJdks5sRWFQgaJpZM4Ns1oB>
> >     > .
> >     >
> >
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at [email protected] or file a JIRA
> ticket
> > with INFRA.
> > ---
> >
>

Reply via email to