Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/13#discussion_r130216751
--- Diff: tests/src/Appender/RollingFileAppenderTest.cs ---
@@ -155,7 +157,17 @@ private static void VerifyFileCount(int iExpectedCount)
/// <param name="iExpectedCount"></param>
--- End diff --
Couldn't we count both files that match `c_fileName` and
`c_fileNameWithFolder`? This way we would only have one
`VerifyFileCount([...])` to invoke from the tests, just like there is one
`DeleteTestFiles()`. This should work fine since the tests also remove both
kinds of logfiles.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
