[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117666#comment-16117666
 ] 

ASF GitHub Bot commented on LOG4J2-1997:
----------------------------------------

Github user rgoers commented on a diff in the pull request:

    https://github.com/apache/logging-log4j2/pull/106#discussion_r131798474
  
    --- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/TimestampMessageTest.java
 ---
    @@ -16,6 +16,9 @@
      */
     package org.apache.logging.log4j.core;
     
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertNotNull;
    --- End diff --
    
    static imports go last. We allow wildcard static imports so this change 
isn't necessary.


> Test classes do not close resources and use deprecated methods
> --------------------------------------------------------------
>
>                 Key: LOG4J2-1997
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1997
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.9
>         Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>            Reporter: kenneth mcfarland
>             Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to