OK, but it's probably good to have appender.stop() there as well, to try
to end cleanly.
And if you to try/catch around the deleteIfExists, it would be good to
log any error, since that might be useful to troubleshoot any future
file permission errors on Jenins.
But I'll let you fix it.
On 2017-11-19 13:02, Remko Popma wrote:
I have a fix, but I’ll hold off pushing it until Ralph is done with the release
that’s in progress.
(It’s just a try/catch FileSystemException around the deleteIfExists in the
finally block on line 174)
(Shameless plug) Every java main() method deserves http://picocli.info
On Nov 19, 2017, at 20:46, Mikael Ståldal <mi...@apache.org> wrote:
Does it help if you add:
appender.stop(10, TimeUnit.SECONDS);
after line 171 in Log4j1ConfigurationFactoryTest.java (last in the try block)?
On 2017-11-19 05:41, Remko Popma wrote:
The build now fails on windows.
I always see this error:
expected: C:\Users\remko\AppData\Local\Temp\/hadoop.log Actual:
C:\Users\remko\AppData\Local\Temp\/hadoop.log
java.nio.file.FileSystemException:
C:\Users\remko\AppData\Local\Temp\hadoop.log: The process cannot access the
file because it is being used by another process.
at
sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:86)
at
sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97)
at
sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102)
at
sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:269)
at
sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(AbstractFileSystemProvider.java:108)
at java.nio.file.Files.deleteIfExists(Files.java:1116)
at
org.apache.log4j.config.Log4j1ConfigurationFactoryTest.testSystemProperties1(Log4j1ConfigurationFactoryTest.java:173)
