Why are there 5 commits in a row for the same Jira issue? Is there are reason you don’t test it all before committing? If you need to commit piecemeal then please squash the commits.
Ralph > On Jan 12, 2018, at 10:15 PM, [email protected] wrote: > > Repository: logging-log4j2 > Updated Branches: > refs/heads/master 3c584bedb -> a925d9e97 > > > [LOG4J2-2185] Add a simple JDBC DriverManager-based ConnectionSource > that uses JDBC's DriverManager#getConnection(String, String, String). > Use @PluginBuilderFactory. > > Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo > Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/a925d9e9 > Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/a925d9e9 > Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/a925d9e9 > > Branch: refs/heads/master > Commit: a925d9e9750911bb5d904be8f51e5ce7c5912b24 > Parents: 3c584be > Author: Gary Gregory <[email protected]> > Authored: Fri Jan 12 22:15:08 2018 -0700 > Committer: Gary Gregory <[email protected]> > Committed: Fri Jan 12 22:15:08 2018 -0700 > > ---------------------------------------------------------------------- > .../core/appender/db/jdbc/DriverManagerConnectionSourceTest.java | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > ---------------------------------------------------------------------- > > > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/a925d9e9/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jdbc/DriverManagerConnectionSourceTest.java > ---------------------------------------------------------------------- > diff --git > a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jdbc/DriverManagerConnectionSourceTest.java > > b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jdbc/DriverManagerConnectionSourceTest.java > index acd906a..5a4835a 100644 > --- > a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jdbc/DriverManagerConnectionSourceTest.java > +++ > b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jdbc/DriverManagerConnectionSourceTest.java > @@ -35,7 +35,7 @@ public class DriverManagerConnectionSourceTest { > // @formatter:on > }; > // @formatter:off > - DriverManagerConnectionSource source = new > DriverManagerConnectionSource.Builder<>() > + DriverManagerConnectionSource source = > DriverManagerConnectionSource.newBuilder() > .setConnectionString(JdbcH2TestHelper.CONNECTION_STRING) > .setProperties(properties) > .build(); > @@ -48,7 +48,7 @@ public class DriverManagerConnectionSourceTest { > @Test > public void testH2UserAndPassword() throws SQLException { > // @formatter:off > - DriverManagerConnectionSource source = new > DriverManagerConnectionSource.Builder<>() > + DriverManagerConnectionSource source = > DriverManagerConnectionSource.newBuilder() > .setConnectionString(JdbcH2TestHelper.CONNECTION_STRING) > .setUserName(JdbcH2TestHelper.USER_NAME.toCharArray()) > .setPassword(JdbcH2TestHelper.PASSWORD.toCharArray()) > >
