> On Jul 14, 2018, at 10:49, Remko Popma <remko.po...@gmail.com> wrote:
> 
> Be careful in this area. I remember this was quite tricky!
> 
> Please step through the code in a debugger to make sure it does what you 
> think it does before making changes. 

Also maybe start with a failing test case. 
Is there an actual problem or did you just notice that the code looks like it 
won’t work?

> 
> Remko 
> 
>>> On Jul 14, 2018, at 9:  27, Gary Gregory <garydgreg...@gmail.com> wrote:
>>> 
>>> On Fri, Jul 13, 2018 at 6:22 PM Gary Gregory <garydgreg...@gmail.com> wrote:
>>> 
>>> Hi All:
>>> 
>>> Looks like a bug and not by design in:
>>> 
>>> org.apache.logging.log4j.core.appender.rolling.RollingFileManager.RollingFileManager(LoggerContext,
>>> String, String, OutputStream, boolean, boolean, long, long,
>>> TriggeringPolicy, RolloverStrategy, String, Layout<? extends Serializable>,
>>> String, String, String, boolean, ByteBuffer)
>>> 
>>> Note the hard coded false.
>>> 
>>> Which I will fix unless someone can convince me otherwise.
>>> 
>> 
>> Same for RollingRandomAccessFileManager.
>> 
>> Gary
>> 
>> 
>>> 
>>> Gary
>>> 

Reply via email to