I am sure we can find a way to eliminate our custom time code or base it on java.time. Whether it performs better or not would require that it be tested and compared. It wouldn’t be a simple matter to create a JMH benchmark and create our time formatting against java.time.
Ralph > On Nov 4, 2018, at 10:33 AM, Gary Gregory <[email protected]> wrote: > > Some notes. > > Java 8 provides a java.time package. It would be nice to reuse it instead > of keeping our own Java 7-based code. > > We provide a MutableInstant class akin to the final immutable thread-safe > java.time.Instant class. > > Our class is not interchangeable with java.time.Instant but it could be a > little more playful by implementing the java.time interfaces Temporal, > TemporalAdjuster, Comparable<Instant>. > > Java 8 also provides Clock classes. We do as well. Our clocks initialize > MutableInstant instances. > > It does not seem possible to move from our custom time code to java.time. > > It should be possible to update TimeFilter to use java.time, but I wonder > if it would be as performant. > > Thoughts? > > Gary
