Yeah, that format and library is designed around Java in mind and Scala as a downstream user (unlike most Lightbend things which are Scala-first).
On Mon, 5 Nov 2018 at 15:03, Gary Gregory <[email protected]> wrote: > On Mon, Nov 5, 2018 at 2:02 PM Gary Gregory <[email protected]> > wrote: > > > On Mon, Nov 5, 2018 at 1:59 PM Matt Sicker <[email protected]> wrote: > > > >> I like the HOCON format for duration values: > >> > https://github.com/lightbend/config/blob/master/HOCON.md#duration-format > > > > > > That looks easy to map to Java TimeUnit. > > > > I could see augmenting HttpCore's TimeValue to support those. > > Gary > > > > > > Gary > > > > > >> > >> > >> On Mon, 5 Nov 2018 at 14:53, Gary Gregory <[email protected]> > wrote: > >> > >> > On Mon, Nov 5, 2018 at 1:50 PM Ralph Goers < > [email protected]> > >> > wrote: > >> > > >> > > I have no problem with this but would think it would be something we > >> > would > >> > > want to do in 3.0 and not 2.x. Rather than to keep introducing > >> features > >> > to > >> > > 2.x I’d like to concentrate a bit on figuring out what things really > >> need > >> > > to be changed for a 3.0 release and adding new significant features > >> > there. > >> > > > >> > > >> > That's fine with me. > >> > > >> > Gary > >> > > >> > > >> > > Ralph > >> > > > >> > > > On Nov 5, 2018, at 11:54 AM, Gary Gregory <[email protected] > > > >> > > wrote: > >> > > > > >> > > > Hi All: > >> > > > > >> > > > Today in appenders like the JMS Appender you can specify time > values > >> > like > >> > > > the setting reconnectIntervalMillis="5000"; same idea with the > >> > mysterious > >> > > > Configuration monitorInterval which is specified in seconds (how > >> would > >> > > you > >> > > > know that without digging in the docs? ;-) > >> > > > > >> > > > What I'd like to see instead is the ability to say > >> reconnectInterval="5 > >> > > > SECONDS" and monitorInterval="2 MINUTES". Note the unscaled > >> attribute > >> > > name. > >> > > > > >> > > > The scale word is a java.util.concurrent.TimeUnit enum name (with, > >> say, > >> > > an > >> > > > optional "S" at the end). I'm not thinking about localization ATM, > >> just > >> > > use > >> > > > the TimeUnit enum names. > >> > > > > >> > > > Over in Apache HttpComponents HttpCore, I created the very handy > >> > > TimeValue > >> > > > class for this purpose which holds a value and a TimeUnit: > >> > > > > >> > > > >> > > >> > https://github.com/apache/httpcomponents-core/blob/master/httpcore5/src/main/java/org/apache/hc/core5/util/TimeValue.java > >> > > > > >> > > > Then instead of passing around opaque longs and ints around the > >> code, > >> > you > >> > > > pass arounds TimeValues. > >> > > > > >> > > > In either 2.x or 3.x, I'd like to copy this class and use it. > >> > > > > >> > > > Thoughts? > >> > > > > >> > > > Gary > >> > > > > >> > > > PS: In HttpCore, TimeValue also has a subclass Timeout. > >> > > > >> > > > >> > > > >> > > >> > >> > >> -- > >> Matt Sicker <[email protected]> > >> > > > -- Matt Sicker <[email protected]>
