Gary, if you want to contribute patches for AsciiDoctor go for it. I simply don’t have time. They have basically admitted that when generating the body AsciiDoctor ignores the Maven Site theme, which is the root of the problem. I’m not even sure that their proposed solution of using an AsciiDoctor extension would work since the site plugin uses Doxia which, as I understand it, is requires Doxia modules to provide unrendered data to it so that all the HTML is really being generated by Doxia.
At this point I am convinced we have to switch back to Markdown or xdoc where Markdown doesn’t work. Either that or we abandon the site plugin to generate the Log4j web site. Ralph > On Apr 29, 2019, at 11:25 AM, Gary Gregory <[email protected]> wrote: > > Based on the reply to my comment I just saw on the github page for the > issue, it seems like the developer is willing to help, we just need to > provide PRs or a description of what we'd like to change... > > Gary > > On Mon, Apr 29, 2019 at 12:48 PM Ralph Goers <[email protected]> > wrote: > >> The issue isn’t marked as fixed. The problem I am having is that tables >> are rendered without borders. This is because asciidoc doesn’t include its >> css file when building the site because the “normal” asciidoc css would >> break the site. Asciidoc generates tables with css class names to generate >> the borders and grids. According to the Jira issue other markup has the >> same issue. >> >> Ralph >> >>> On Apr 29, 2019, at 8:50 AM, Matt Sicker <[email protected]> wrote: >>> >>> I had converted them to asciidoc a while back because it provided more >>> syntactical features than markdown. Many of the files I converted >>> weren't markdown but xdoc. >>> >>> Also, there was a new asciidoctor release just the other day. Unsure >>> if it's related. >>> >>> On Mon, 29 Apr 2019 at 10:34, Ralph Goers <[email protected]> >> wrote: >>>> >>>> The master branch was converted to use AsciiDoctor. To be honest, I >> don’t remember why. But after trying to create a new page with it I >> discovered that AsciiDoctor simply doesn’t work properly with the Maven >> Site Plugin. See >> https://github.com/asciidoctor/asciidoctor-maven-plugin/issues/166 < >> https://github.com/asciidoctor/asciidoctor-maven-plugin/issues/166>. As >> such I believe the site documents in Master need to be converted back to >> Markdown. >>>> >>>> Ralph >>> >>> >>> >>> -- >>> Matt Sicker <[email protected]> >>> >> >> >>
