I did some a benchmark as I had the same thought. FastDateFormat is faster than java.time.
Ralph > On Jan 29, 2020, at 7:34 AM, Matt Sicker <[email protected]> wrote: > > Oh right. We might’ve checked that out at one point. Escape analysis might > optimize away some of the garbage, but not predictably. > > On Wed, Jan 29, 2020 at 05:53 Volkan Yazıcı <[email protected]> wrote: > >> To the best of my knowledge, FastDateFormat is garbage-free and >> available options in JDK 8+ are not. >> >> On Tue, Jan 28, 2020 at 11:40 PM Matt Sicker <[email protected]> wrote: >>> >>> I've started browsing through your PR. It's given me a tangential >>> question that I didn't feel like leaving on the PR: I see the >>> continued use of our FastDateTime classes from Commons, and now I'm >>> wondering if we still need to use this in Java 8? Could be worth >>> exploring. >>> >>> I also noted some clarifications on how plugin dependency injection >>> currently works so you can simplify some of your wrappers if desired. >>> >>> On Tue, 28 Jan 2020 at 13:59, Volkan Yazıcı <[email protected]> >> wrote: >>>> >>>> I've just created a PR[1] contributing LogstashLayout to Log4j core. >>>> Please see the GitHub link for the feedback/support requests. I will >>>> appreciate a quick review cycle, since I will try my best to invest >>>> quite some time into this during FOSDEM. >>>> >>>> [1] https://github.com/apache/logging-log4j2/pull/335 >>> >>> >>> >>> -- >>> Matt Sicker <[email protected]> >> > -- > Matt Sicker <[email protected]>
