Yes, I have added it to my local copy and am running the site build (for the nth time) in preparation for the release.
Ralph > On Nov 6, 2020, at 8:40 AM, Matt Sicker <boa...@gmail.com> wrote: > > There's supposed to be a variable declaration at the top of the > velocity file to define the dollar variable to '$'. It's not automatic > from what I remember, so copy/paste from another .vm file. :) > > On Fri, 6 Nov 2020 at 06:51, Volkan Yazıcı <volkan.yaz...@gmail.com> wrote: >> >> Hello, >> >> json-template-layout.adoc.vm (in both release-2.x and master branches) gets >> processed in such a way that dollar ($) characters are not properly >> handled. That is, after `./mvnw site`, json-template-layout.html still >> contains "${dollar}" snippets. >> >> Note that there are various usages of dollar ($) character in the file. >> Some in the code snippets, some in the paragraphs, etc. In particular, in >> the following paragraph: >> >> Yes, link:lookups.html[lookups] (e.g., `${dollar}{java:version}`, >> `${dollar}{env:USER}`, `${dollar}{date:MM-dd-yyyy}`) are supported in string >> literals of templates. Though note that they are not garbage-free. >> >> ${dollar} literals converted to HTML as is. If I replace them with a single >> dollar ($) character, this time I get the following error during >> compilation: >> >> [*ERROR*] Failed to execute goal >> org.apache.maven.plugins:maven-site-plugin:3.8.2:site *(default-site)* >> on project log4j: *Error parsing >> src/site/asciidoc/manual/json-template-layout.adoc.vm as a Velocity >> template: Encountered ":version}`,\n`" at >> /home/vy/Projects/log4j/2/src/site/asciidoc/manual/json-template-layout.adoc.vm[line >> 1236, column 47]* >> >> Does anybody have an idea on how to fix this, please? >> >> Kind regards. >