I wonder if we could give ourselves guidelines like: - any change to an algorithm is not trivial (I know, i know, every line of code can be considered an algorithm) - any change created by a tool is trivial, like clean ups that remove trailing whitespace, reflectors code and so on. The issue is that the PR comment might not say that a tool was used.
I wonder if CYA would simply default us to asking for the paperwork. Most projects backed by for profit corporations do that. Gary On Wed, Feb 3, 2021, 10:28 Matt Sicker <boa...@gmail.com> wrote: > It has more to do with copyright. Trivial changes aren't copyrightable > or can be trivially verified to be public domain or similar. Think > things like typos, one-liners, etc. > > If you merge a PR from someone without an ICLA, basically, you're > taking the responsibility of saying "I verified this code has been > legally contributed to us under the correct license". Having an ICLA > on file from the contributor moves that responsibility back to them > for clearing their own contributions. > > On Wed, 3 Feb 2021 at 09:10, Volkan Yazıcı <volkan.yaz...@gmail.com> > wrote: > > > > Would you briefly define *non-trivial changes*, please? I can imagine it > > might be difficult to come up with a precise definition, though I would > > like to hear one. Is it measured by LoC changes? If so, that is a pretty > > objective criteria. Is it measured by the impact? If so, that is a pretty > > subjective criteria. > > > > On Wed, Feb 3, 2021 at 3:53 PM Matt Sicker <boa...@gmail.com> wrote: > > > > > ICLAs are needed from people who contribute non-trivial changes and > > > haven't already filled one out. There's a list of names who already > > > submitted ICLAs on this page: > > > https://home.apache.org/unlistedclas.html > > > > > > On Wed, 3 Feb 2021 at 08:17, Volkan Yazıcı <volkan.yaz...@gmail.com> > > > wrote: > > > > > > > > Hello, > > > > > > > > Recently we have requested a signed ICLA from Tim Perry for his work > > > > available at GitHub PR #463 > > > > <https://github.com/apache/logging-log4j2/pull/463> addressing > > > LOG4J2-1606 > > > > and LOG4J2-2624. That said, there have been occasions of me merging > PRs > > > > from individuals without requesting a signed ICLA, e.g., #462 > > > > <https://github.com/apache/logging-log4j2/pull/462>, #461 > > > > <https://github.com/apache/logging-log4j2/pull/461>, #436 > > > > <https://github.com/apache/logging-log4j2/pull/436>. What is the > > > official > > > > procedure on this? Are we supposed to not accept any PR without an > ICLA > > > > first? What if we/I did? > > > > > > > > Kind regards. > > > >
