I don't think we need to fail the RC if the site generation is the only item impacted as opposed to the running software since its relatively easy to fix the site after the release. Up to the RM of course ;-)
Gary On Sun, Mar 7, 2021, 15:58 Ralph Goers <ralph.go...@dslextreme.com> wrote: > See - https://issues.apache.org/jira/projects/MDOAP/issues/MDOAP-61. This > is documented as part of the release process. > > I don’t understand the impact of the missing json-template-layout.html. > Is that from the web site? Was it present in 2.14.0 and why is it missing > now? > > Ralph > > > > > On Mar 7, 2021, at 1:37 PM, Volkan Yazıcı <volkan.yaz...@gmail.com> > wrote: > > > > -1, due to missing `json-template-layout.html` file! > > > > `./mvnw site` fails for me thanks to maven-doap-plugin: > > > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-doap-plugin:1.2:generate (site) on project > > log4j: Execution site of goal > > org.apache.maven.plugins:maven-doap-plugin:1.2:generate failed: An API > > incompatibility was encountered while executing > > org.apache.maven.plugins:maven-doap-plugin:1.2:generate: > > java.lang.ExceptionInInitializerError: null > > [ERROR] ----------------------------------------------------- > > [ERROR] realm = plugin>org.apache.maven.plugins:maven-doap-plugin:1.2 > > [ERROR] strategy = > > org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy > > [ERROR] urls[0] = > > > file:/home/vy/.m2/repository/org/apache/maven/plugins/maven-doap-plugin/1.2/maven-doap-plugin-1.2.jar > > [ERROR] urls[1] = > > > file:/home/vy/.m2/repository/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar > > [ERROR] urls[2] = > > file:/home/vy/.m2/repository/junit/junit/3.8.1/junit-3.8.1.jar > > [ERROR] urls[3] = > > > file:/home/vy/.m2/repository/org/apache/maven/scm/maven-scm-api/1.9.2/maven-scm-api-1.9.2.jar > > [ERROR] urls[4] = > > > file:/home/vy/.m2/repository/org/apache/maven/scm/maven-scm-manager-plexus/1.9.2/maven-scm-manager-plexus-1.9.2.jar > > [ERROR] urls[5] = > > > file:/home/vy/.m2/repository/org/apache/maven/scm/maven-scm-provider-svn-commons/1.9.2/maven-scm-provider-svn-commons-1.9.2.jar > > [ERROR] urls[6] = > > > file:/home/vy/.m2/repository/org/apache/maven/scm/maven-scm-provider-svnexe/1.9.2/maven-scm-provider-svnexe-1.9.2.jar > > [ERROR] urls[7] = > > > file:/home/vy/.m2/repository/commons-lang/commons-lang/2.6/commons-lang-2.6.jar > > [ERROR] urls[8] = > > > file:/home/vy/.m2/repository/org/apache/maven/scm/maven-scm-provider-cvs-commons/1.9.2/maven-scm-provider-cvs-commons-1.9.2.jar > > [ERROR] urls[9] = > > > file:/home/vy/.m2/repository/org/apache/maven/scm/maven-scm-provider-cvsexe/1.9.2/maven-scm-provider-cvsexe-1.9.2.jar > > [ERROR] urls[10] = > > > file:/home/vy/.m2/repository/org/apache/maven/scm/maven-scm-provider-cvsjava/1.9.2/maven-scm-provider-cvsjava-1.9.2.jar > > [ERROR] urls[11] = > > > file:/home/vy/.m2/repository/org/netbeans/lib/cvsclient/20060125/cvsclient-20060125.jar > > [ERROR] urls[12] = > > > file:/home/vy/.m2/repository/ch/ethz/ganymed/ganymed-ssh2/build210/ganymed-ssh2-build210.jar > > [ERROR] urls[13] = > > > file:/home/vy/.m2/repository/org/codehaus/plexus/plexus-utils/3.0.20/plexus-utils-3.0.20.jar > > [ERROR] urls[14] = > > > file:/home/vy/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.21/plexus-interpolation-1.21.jar > > [ERROR] urls[15] = > > > file:/home/vy/.m2/repository/org/codehaus/plexus/plexus-i18n/1.0-beta-10/plexus-i18n-1.0-beta-10.jar > > [ERROR] urls[16] = > > file:/home/vy/.m2/repository/com/hp/hpl/jena/jena/2.6.3/jena-2.6.3.jar > > [ERROR] urls[17] = > > file:/home/vy/.m2/repository/com/hp/hpl/jena/iri/0.8/iri-0.8.jar > > [ERROR] urls[18] = > > file:/home/vy/.m2/repository/com/hp/hpl/jena/iri/0.8/iri-0.8-sources.jar > > [ERROR] urls[19] = > > file:/home/vy/.m2/repository/com/ibm/icu/icu4j/3.4.4/icu4j-3.4.4.jar > > [ERROR] urls[20] = > > file:/home/vy/.m2/repository/xerces/xercesImpl/2.7.1/xercesImpl-2.7.1.jar > > [ERROR] urls[21] = > > > file:/home/vy/.m2/repository/org/slf4j/slf4j-log4j12/1.5.8/slf4j-log4j12-1.5.8.jar > > [ERROR] urls[22] = > > file:/home/vy/.m2/repository/log4j/log4j/1.2.13/log4j-1.2.13.jar > > [ERROR] urls[23] = > > > file:/home/vy/.m2/repository/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar > > [ERROR] urls[24] = > > > file:/home/vy/.m2/repository/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar > > [ERROR] urls[25] = > > > file:/home/vy/.m2/repository/commons-codec/commons-codec/1.2/commons-codec-1.2.jar > > [ERROR] Number of foreign imports: 1 > > [ERROR] import: Entry[import from realm ClassRealm[maven.api, parent: > > null]] > > [ERROR] > > [ERROR] ----------------------------------------------------- > > [ERROR] : Invalid version number: Version number may be negative or > greater > > than 255 > > > > I don't know if this is something already known. Then I fall back to > > `./mvnw site -DskipTests=true -Dmaven.doap.skip=true`. > > > > `layout.html` looks good, but *I could not locate > > `json-template-layout.html`. Instead, there is a > > `json-template-layout.vm.html` file. Would you mind confirming > > `json-template-layout.html` gets generated, please?* > > > > I will also appreciate the small correction for `layouts.xml.vm` I share > > below, though feel free to ignore it if you think this blocks the > release. > > > > diff --git a/src/site/xdoc/manual/layouts.xml.vm > > b/src/site/xdoc/manual/layouts.xml.vm > > index 52b415dd9..30361d9ac 100644 > > --- a/src/site/xdoc/manual/layouts.xml.vm > > +++ b/src/site/xdoc/manual/layouts.xml.vm > > @@ -208,13 +208,14 @@ logger.debug("one={}, two={}, three={}", 1, 2, 3); > > }, > > "exception_message": { > > "${dollar}resolver": "exception", > > - "field": "message", > > - "stringified": true > > + "field": "message" > > }, > > "stacktrace": { > > "${dollar}resolver": "exception", > > "field": "stackTrace", > > - "stringified": true > > + "stackTrace": { > > + "stringified": true > > + } > > } > > }, > > "line_number": { > > > > This has slipped through my eyes while backporting forwarded-ported > > LOG4J2-2993. > > > > Besides these documentation & site related issues, `./mvnw clean verify` > > works for me. > > OS: Ubuntu 20.04.2 LTS > > JDK 8: 1.8.0_272 (AdoptOpenJDK) > > JDK 9+: 11.0.6+10 (AdoptOpenJDK) > > > > Kind regards. > > > > On Sun, Mar 7, 2021 at 7:46 AM Ralph Goers <ralph.go...@dslextreme.com> > > wrote: > > > >> This is a vote to release Log4j 2.14.1, the next version of the Log4j 2 > >> project. > >> > >> Please download, test, and cast your votes on the log4j developers list. > >> [] +1, release the artifacts > >> [] -1, don't release because... > >> > >> The vote will remain open for 72 hours (or more if required). All votes > >> are welcome and we encourage everyone to test the release, but only > Logging > >> PMC votes are “officially” counted. As always, at least 3 +1 votes and > more > >> positive than negative votes are required. > >> > >> Changes in this release include: > >> > >> New Features > >> > >> • LOG4J2-2962: Enrich "map" resolver by unifying its backend with > >> "mdc" resolver. > >> • LOG4J2-2999: Replace JsonTemplateLayout resolver configurations > >> table in docs with sections. > >> • LOG4J2-2993: Support stack trace truncation in > >> JsonTemplateLayout. > >> Fixed Bugs > >> > >> • LOG4J2-3033: Add log method with no parameters - i.e. it has an > >> empty message. > >> • LOG4J2-2947: Document that LogBuilder default methods do > nothing. > >> • LOG4J2-2948: Replace HashSet with IdentityHashMap in > >> ParameterFormatter to detect cycles. > >> • LOG4J2-3028: OutputStreamManager.flushBuffer always resets the > >> buffer, previously the buffer was not reset after an exception. Thanks > to > >> Jakub Kozlowski. > >> • LOG4J2-2981: OnStartupTriggeringPolicy would fail to cause the > >> file to roll over with DirectWriteTriggeringPolicy unless minSize was > set > >> to 0. > >> • LOG4J2-2990: Reduce garbage by using putAll when copying the > >> ThreadContext for SLF4J. Thanks to Diogo Monteiro. > >> • LOG4J2-3006: Directly create a thread instead of using the > >> common ForkJoin pool when initializing ThreadContextDataInjector" > >> • LOG4J2-2624: Allow auto-shutdown of log4j in log4j-web to be > >> turned off and provide a ServletContextListener > >> "Log4jShutdownOnContextDestroyedListener" to stop log4j. Register the > >> listener at the top of web.xml to ensure the shutdown happens last. > Thanks > >> to Tim Perry. > >> • LOG4J2-1606: Allow auto-shutdown of log4j in log4j-web to be > >> turned off and provide a ServletContextListener > >> "Log4jShutdownOnContextDestroyedListener" to stop log4j. Register the > >> listener at the top of web.xml to ensure the shutdown happens last. > Thanks > >> to Tim Perry. > >> • LOG4J2-2998: Fix truncation of excessive strings ending with a > >> high surrogate in JsonWriter. > >> • LOG4J2-2973: Rename EventTemplateAdditionalField#type > >> (conflicting with properties file parser) to "format". Thanks to Fabio > >> Ricchiuti. > >> • LOG4J2-2972: Refactor AsyncAppender and AppenderControl for > >> handling of Throwables. > >> • LOG4J2-2985: Add eventTemplateRootObjectKey parameter to > >> JsonTemplateLayout. > >> • LOG4J2-2974: Log4j would fail to initialize in Java 8 with > >> log4j-spring-boot. > >> • LOG4J2-2964: Merge packages from several Configurations in > >> Composite Configuration. Thanks to Valery Yatsynovich. > >> • LOG4J2-2961: Fix reading of JsonTemplateLayout event additional > >> fields from config. > >> • LOG4J2-2916: Avoid redundant Kafka producer instantiation > >> causing thread leaks. Thanks to wuqian0808. > >> • LOG4J2-2967: Fix JsonTemplateLayout index based parameter > >> resolution when messages contain too few parameters. > >> • LOG4J2-2976: JdbcAppender composes an incorrect INSERT > statement > >> without a ColumnMapping element. > >> • LOG4J2-3014: Log4j1ConfigurationConverter on Windows produces " > >> " at end of every line. Thanks to Lee Breisacher, Gary Gregory. > >> Changes > >> > >> • LOG4J2-2893: Allow reconfiguration when Log4j 1 configuration > >> files are updated. > >> • : Update Spring dependencies to 5.3.2, Spring Boot to 2.3.6, > and > >> Spring Cloud to Hoxton.SR9 > >> • : Update org.fusesource.jansi:jansi 1.17.1 -> 2.0.1. > >> • : Update commons-codec:commons-codec 1.14 -> 1.15. > >> • : Update org.apache.commons:commons-lang3 3.10 -> 3.11. > >> • : Update org.apache.commons:commons-pool2 2.8.1 -> 2.9.0. > >> • : Update org.apache.commons:commons-dbcp2 2.4.0 -> 2.8.0. > >> • : Update commons-io:commons-io 2.7 -> 2.8.0. > >> • : Update org.codehaus.groovy:* 3.0.5 -> 3.0.6. > >> • : Update com.fasterxml.jackson.: 2.11.2 - 2.11.3. > >> • : Update org.springframework:* 5.2.8.RELEASE -> 5.3.1. > >> • : Update junit:junit 4.13 -> 4.13.1. > >> • : Update org.xmlunit:* 2.7.0 -> 2.8.0. > >> • : Update org.assertj:assertj-core 3.14.0 -> 3.18.1. > >> • : Update org.awaitility:awaitility 4.0.2 -> 4.0.3. > >> • : Update org.codehaus.plexus:plexus-utils 3.2.0 -> 3.3.0. > >> • : Update MongoDB 3 plugin: org.mongodb:mongodb-driver 3.12.6 -> > >> 3.12.7. > >> • : Update MongoDB 4 plugin: org.mongodb:* 4.1.0 -> 4.1.1. > >> • : Update org.eclipse.tycho:org.eclipse.osgi > >> 3.12.1.v20170821-1548 -> 3.13.0.v20180226-1711. > >> • : Update de.flapdoodle.embed:de.flapdoodle.embed.mongo 2.2.0 -> > >> 3.0.0. > >> • : Update net.javacrumbs.json-unit:json-unit 1.31.1 -> 2.22.0. > >> • : Update Mockito 3.6.0 -> 3.7.0. > >> • : Update XML Unit 2.8.0 -> 2.8.2. > >> • : Update JSON Unit 2.21.0 -> 2.22.0. > >> • : Update JaCoCo 0.8.3 -> 0.8.6. > >> • : Update org.apache.activemq:* 5.16.0 -> 5.16.1. > >> • : Update org.mockito:mockito-* 3.7.0 -> 3.7.7. > >> • : Update org.springframework:* 5.3.2 -> 5.3.3. > >> • : Update mongodb4.version 4.1.1 -> 4.2.0. > >> • : Update org.fusesource.jansi:jansi 1.18 -> 2.2.0. > >> • : Update org.assertj:assertj-core 3.18.1 -> 3.19.0. > >> • : Update net.javacrumbs.json-unit:json-unit 2.22.0 -> 2.23.0. > >> • : Update Woodstox 5.0.3 -> 6.2.3 to match Jackson 2.12.1. > >> • : Update org.apache.activemq:* 5.16.0 -> 5.16.1. > >> • : Update org.mockito:mockito-* 3.7.0 -> 3.7.7. > >> • : Update org.springframework:* 5.3.2 -> 5.3.3. > >> • : Update mongodb4.version 4.1.1 -> 4.2.0. > >> • : Update org.fusesource.jansi:jansi 1.18 -> 2.3.1. > >> • : Update org.assertj:assertj-core 3.18.1 -> 3.19.0. > >> • : Update net.javacrumbs.json-unit:json-unit 2.22.0 -> 2.23.0. > >> • : Update net.javacrumbs.json-unit:json-unit 2.22.0 -> 2.23.0. > >> • com.fasterxml.jackson.core:jackson-annotations > >> ................. 2.12.1 -> 2.12.2 > >> - com.fasterxml.jackson.core:jackson-core > >> ........................ 2.12.1 -> 2.12.2 > >> - com.fasterxml.jackson.core:jackson-databind > >> .................... 2.12.1 -> 2.12.2 > >> - com.fasterxml.jackson.dataformat:jackson-dataformat-xml > >> ........ 2.12.1 -> 2.12.2 > >> - com.fasterxml.jackson.dataformat:jackson-dataformat-yaml > >> ....... 2.12.1 -> 2.12.2 > >> - > >> com.fasterxml.jackson.module:jackson-module-jaxb-annotations ... 2.12.1 > -> > >> 2.12.2 > >> - org.apache.commons:commons-lang3 > >> ............................... 3.11 -> 3.12.0 > >> - org.junit.jupiter:junit-jupiter-engine > >> ......................... 5.7.0 -> 5.7.1 > >> - org.junit.jupiter:junit-jupiter-migrationsupport > >> ............... 5.7.0 -> 5.7.1 > >> - org.junit.jupiter:junit-jupiter-params > >> ......................... 5.7.0 -> 5.7.1 > >> - org.junit.vintage:junit-vintage-engine > >> ......................... 5.7.0 -> 5.7.1 > >> - org.mockito:mockito-core > >> ....................................... 3.7.7 -> 3.8.0 > >> - org.mockito:mockito-junit-jupiter > >> .............................. 3.7.7 -> 3.8.0 > >> - org.mongodb:bson > >> ............................................... 4.2.0 -> 4.2.2 > >> - org.mongodb:mongodb-driver-sync > >> ................................ 4.2.0 -> 4.2.2 > >> > >> Tag: > >> a) for a new copy do "git clone > >> https://github.com/apache/logging-log4j2.git"; and then "git checkout > >> tags/log4j-2.14.1-rc1” or just "git clone -b log4j-2.14.1-rc1 > >> https://github.com/apache/logging-log4j2.git"; > >> b) for an existing working copy to “git pull” and then “git checkout > >> tags/log4j-2.14.1-rc1” > >> > >> Web Site: https://logging.staged.apache.org/log4j/2.x/index.html. > >> > >> Maven Artifacts: > >> > https://repository.apache.org/content/repositories/orgapachelogging-1062 > >> > >> Distribution archives: > >> https://dist.apache.org/repos/dist/dev/logging/log4j/ > >> > >> You may download all the Maven artifacts by executing: > >> wget -e robots=off --cut-dirs=7 -nH -r -p -np --no-check-certificate > >> > https://repository.apache.org/content/repositories/orgapachelogging-1062/org/apache/logging/log4j/ > >> > >> Ralph > >> > >> > >> > >> > > >
