I am ok with formatting code but I want to do it in Eclipse. I did not even notice the POM was changed. I would think it better (for me at least) if an Eclipse config file was provided I can just import, then when I format the code for a method/class/package, the same formatting applies (as whatever created this PR) while respecting the formatter's off/on directives. Gary
On Thu, Jan 13, 2022, 03:58 Jochen Wiedmann <[email protected]> wrote: > On Thu, Jan 13, 2022 at 4:23 AM Carter Kozak <[email protected]> wrote: > > > We've discussed the idea of using a code formatter before, I finally had > a moment put up an example. Please take a look and provide feedback at your > convenience :-) > > https://github.com/apache/logging-log4j2/pull/697 > > The main problem, that I see with that: Your PR should (IMO) provide > only the changes in the POM, or whatever else is required to introduce > the code formatter, so as to enable the changes in the actual code as > a second step. > > Jochen > > > -- > Philosophy is useless, theology is worse. (Industrial Desease, Dire > Straits) >
