There is only one flaw with that argument. When I did release 2.17.2 we weren’t 
having random test failures like this. So something changed.

Ralph

> On May 28, 2022, at 11:34 AM, Matt Sicker <[email protected]> wrote:
> 
> Oh, and if these tests used to work, they wouldn’t be flaking from unrelated 
> changes such as when someone updates a README file or other non-code area 
> that somehow results in a failed CI run.
> —
> Matt Sicker
> 
>> On May 28, 2022, at 10:29, Matt Sicker <[email protected]> wrote:
>> 
>> I sent a separate email complaining about how Dependabot does this. Anyways, 
>> the disabled tests are flakes. As I’ve said before, I run the full build and 
>> suite of tests locally before pushing commits, but I’ve been getting tons of 
>> build failure emails regardless. So instead of ignoring CI failures as seems 
>> to be standard right now, I disabled the flaky tests where applicable until 
>> someone cares enough to fix them. I filed Jira issues so we don’t forget, 
>> either. It was also the only real feasible way to get through dependency 
>> upgrade PRs without them randomly failing due to unrelated flaky tests.
>> 
>> —
>> Matt Sicker
>> 
>>> On May 28, 2022, at 03:46, Piotr P. Karwasz <[email protected]> wrote:
>>> 
>>> Hi Ralph,
>>> 
>>> On Sat, 28 May 2022 at 10:17, Ralph Goers <[email protected]>
>>> wrote:
>>> 
>>>> What I don’t understand is why several of the Jira issues seemingly have
>>>> 100 commits on various branches and flooded my inbox with email.
>>>> 
>>>> This is Dependabot-related: every time a commit with "LOG4J2" appears in
>>> *any* branch, JIRA sends an e-mail. Rebasing many Dependabot branches
>>> caused a storm of e-mails (I had some 150 e-mails this morning).
>>> 
>>> Piotr
> 

Reply via email to