Hi Ralph,
On Tue, 28 Jun 2022 at 01:40, Ralph Goers <[email protected]> wrote: > In preparation for the release I am going through changes.xml and am finding > some issues. > 1. The dev attribute should always include the uid of the committer who > performed the commit. > 2. The due-to attribute should be used to acknowledge the individual who > either submitted a PR > or provided enough detailed information about the problem to make fixing > it easy. It should > never include the name of a committer or PMC member. We get our credit > via the dev attribute. > Notice that the wording here is “Thanks to John Doe”. To me it would look > egotistical for the > line to say that the dev is rgoers along with “Thanks to Ralph Goers”. > Why do I need to thank > myself? So, if I understand correctly, the `dev` attribute of an accepted PR should contain the login of the committer that accepted it, while the original author should be in `due-to`? There are many entries in the previous Log4j2 versions that have the same issues you found in 2.18.0. Should we correct them? Piotr
