It sounds like we have a lazy consensus here. Piotr, I see your point. I think we need to point this out in a GitHub Pull Request template <https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository>, which we have none right now. There I also would like to have certain checks anyway:
- Changelog entry - Signed commits - Tests - etc. Created #1207 <https://github.com/apache/logging-log4j2/issues/1207> for this. On Fri, Jan 13, 2023 at 2:42 PM Piotr P. Karwasz <piotr.karw...@gmail.com> wrote: > Hi Volkan, > > On Fri, 13 Jan 2023 at 10:56, Volkan Yazıcı <vol...@yazi.ci> wrote: > > *Question:* Shall we require signed commits? > > I am obviously Ok with signing, but what should we do with unsigned > PRs? I would prefer to document the requirement somewhere (in the PR > template?) so that we don't have to `rebase -f` everything. > > Piotr >
