Those who are concerned can get themselves heard in this thread. In
the worst case, they can toggle the profile to suit their needs. You
are adding a crucial verification which wasn't there before and 2
other PMC members (Matt and I) agree with the implementation approach.
I don't see a blocker here.

On Wed, Sep 13, 2023 at 8:33 AM Piotr P. Karwasz
<piotr.karw...@gmail.com> wrote:
>
> Hi Volkan,
>
> On Wed, 13 Sept 2023 at 08:23, Volkan Yazıcı <vol...@yazi.ci> wrote:
> > Though note that this will introduce a new requirement on the build
> > hosts: Docker Engine accessibility. Hence, it is better to put these
> > behind a Maven profile (`container`?) that one can opt out of.
>
> This is my main concern, do all committers accept tests running on Docker?
> At work I have successfully ran Docker with WSL2, but be aware that
> this changes the way Windows work and other virtualisation
> technologies might need to be reconfigured or will slow down (e.g.
> VirtualBox).
>
> Piotr

Reply via email to