You're right! Apache RAT does run and I missed it, apologies!: -) Gary
On Fri, Sep 15, 2023, 10:42 AM Volkan Yazıcı <vol...@yazi.ci> wrote: > Thanks for the elaborate review Gary. > > > sha512 file points to a non-existent folder "tmp" > > Fixed[1] in `logging-parent` reusable CI scripts. > It will be applicable from now on. > > [1] > https://github.com/apache/logging-parent/commit/daa46ba9a5a9879fe5989f01cdf81798f9e844a8 > > > verify goal does not run apache-rat:check > > It does. This can also be seen from the CI output[2]. (Look for the > `apache-rat:0.15:check` line there.) > > [2] > https://github.com/apache/logging-log4j-jmx-gui/actions/runs/6195943429/job/16821616066 > > On Fri, Sep 15, 2023 at 4:22 PM Gary D. Gregory <ggreg...@apache.org> > wrote: > > > > - ASC seems OK. > > - Can't easily mechanically check sha512 but eyeballing it appears OK. > > - mvn apache-rat:check OK > > - Built OK 'mvn clean verify' > > - Running with 'java -jar target\...jar localhost:333' starts the app > and fails which is fine since I did not try with an actual app. > > - We have ... ZERO unit tests or ITs? Yikes :-( > > > > I'm going +1 just based on the mechanics of building and trust the RM > ran an app ;-) > > > > Test bed: > > > > Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) > > Maven home: C:\java\apache-maven-3.9.4 > > Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program > Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot > > Default locale: en_US, platform encoding: Cp1252 > > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > > > Gary > > > > On 2023/09/15 08:54:45 Volkan Yazıcı wrote: > > > This is a vote to release the Apache Log4j JMX GUI 2.21.0 (RC2). > > > > > > Source repository: https://github.com/apache/logging-log4j-jmx-gui > > > Commit: c3056b340f57e2d6bd66b9f825722c336090d0d2 > > > Distribution: > https://dist.apache.org/repos/dist/dev/logging/log4j-jmx-gui > > > Nexus: > https://repository.apache.org/content/repositories/orgapachelogging-1175 > > > Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0 > > > > > > Please download, test, and cast your votes on this mailing list. > > > > > > [ ] +1, release the artifacts > > > [ ] -1, don't release, because... > > > > > > This vote is open for 24 hours and will pass unless getting a > > > net negative vote count. All votes are welcome and we encourage > > > everyone to test the release, but only the Logging Services PMC > > > votes are officially counted. At least 3 +1 votes and more > > > positive than negative votes are required. > > > > > > # RC1..RC2 changes > > > > > > - Added `Main-Class` to `MANIFEST.MF` > > > > > > # Release Notes > > > > > > This marks the first release where the Log4j JMX GUI is released > > > separately from the Log4j itself. > > > > > > ## Changes > > > > > > ### Added > > > > > > * Project is moved to a new repository[1] with its own release cycle > > > > > > [1] https://github.com/apache/logging-log4j-jmx-gui > > > >
