I think Robert commented out most of that to get rid of the log4j1 dependency. I'm slightly concerned we'll lose a ton of UI functionality in that process, but it's in history if it's still needed, so delete away if you'd like.
For comparison, you can look at the 'chainsaw-with-log4j1-dep' branch. Scott On 9/29/23, Christian Grobmeier <grobme...@apache.org> wrote: > Hi, > > Looking through the code base, I saw lots of code that is commented. Some > classes (maybe because of this) are not even used anymore. I only saw one > class (ChainsawViewer), which might make sense to keep. > > Is it OK to remove this all? Or is there a specific reason for this? > > Some methods are no longer used or empty despite not being commented. I > would also like to remove them when they don't have any purpose. Since they > are public, BC is no longer guaranteed. For a Standalone app like this, I > don't consider this a problem, but I would like to know if there are any > objections. > > Kind regards, > Christian > >
