> On Oct 20, 2023, at 4:09 PM, Christian Grobmeier <grobme...@apache.org> wrote:
>
> On Sat, Oct 21, 2023, at 01:02, Ralph Goers wrote:
>>> On Oct 20, 2023, at 2:38 PM, Christian Grobmeier <grobme...@apache.org>
>>> wrote:
>>>
>>> Hi,
>>>
>>> i just tried to run mvn test/compile etc on audit and wow, i think its a
>>> lot of work.
>>>
>>> What is the target jdk version? It seems as Java 17 already causes lots of
>>> trouble, even with Java 11 I run into issues, if I looked correctly. At
>>> least, this code base does not seem to run on newer VMs
>>
>> I am quite sure it used Java 8. When I start updating it one of the
>> first things will be to upgrade Spring and to Java 11. I’m not quite
>> prepared to upgrade to Spring Boot 3 and Java 17 yet.
>
> What does "not quite prepared" mean - you don't want too, or you can't for a
> technical reason?
>
> I already saw one would have to add this dependency:
>
> <dependency>
> <groupId>javax.annotation</groupId>
> <artifactId>javax.annotation-api</artifactId>
> <version>1.3.2</version>
> </dependency>
>
> For @PreDestroy/Construct
The log4j-catalog-editor is a Spring Boot app. It is currently using a pretty
old version - 1.5.10. It must be upgraded. Upgrading to Spring 2.x isn’t that
big of a deal. But Spring 3.x, which requires Java 17, is a much bigger deal.
It switched from javax to jakarta for one. In addition, when moving to Java 17
and Spring 3 I would also move to Log4j 3.x. However, I am currently working on
testing a fix for a Log4j bug that occurs in Spring Boot 3.x by testing one of
my apps at work. Unfortunately upgrading that app from Spring Boot 2.x to
Spring 3.x is taking time.
In short, to make log4j-audit current moving to Spring 3.x isn’t required and
having it run on Java 11 should be just fine.
Ralph.
