Thanks Volkan -- Matt, I believe release 1.4.0 is ready for a vote. * ASF staging site: https://logging.staged.apache.org/log4j/kotlin/latest/#release-notes-1-4-0 (from branch https://github.com/apache/logging-log4j-kotlin/commits/asf-staging/) * Signed distribution and checksums: https://dist.apache.org/repos/dist/dev/logging/log4j-kotlin/ * Staging repo is orgapachelogging-1251 (closed)
Regards, Raman On Tue, Dec 12, 2023 at 3:33 AM Volkan Yazıcı <vol...@yazi.ci> wrote: > Thanks for the prompt action. 🙏 > I will review the PR. > > Please keep in mind that you don't have sufficient rights to complete a > release. A PMC member should volunteer as an RM (Release Manager), who, in > your case, is Matt, I presume. That is, you can perform the git chores, but > it is Matt who should do the rest of the release instructions > <https://logging.apache.org/logging-parent/latest/#release-instructions>. > > On Mon, Dec 11, 2023 at 11:53 PM Raman Gupta <rocketra...@gmail.com> > wrote: > >> Thanks for the feedback Volkan. The PR with all of these changes is: >> >> https://github.com/apache/logging-log4j-kotlin/pull/56 >> >> Regards, >> Raman >> >> On Thu, Dec 7, 2023 at 5:54 AM Volkan Yazıcı <vol...@yazi.ci> wrote: >> >>> Raman, Matt, great that you want to release the next version of the >>> Log4j Kotlin! Thanks for your time and effort. >>> >>> I see that you forked the `release/1.3.1` branch from the `rel/1.3.0` >>> tag, though this misses some minor, but important changes (e.g., SBOM & >>> VDR!) from `main`. I suggest we fork from `main` and release `1.4.0` >>> instead. >>> >> >> Done >> >> >>> There are some chores that have been waiting for the next release to be >>> performed. I will share them below and appreciate it if you can carry them >>> out. >>> >>> *Add `project.build.outputTimestamp` Maven property* >>> >>> Please copy this property (incl. the large comment block preceding it!) >>> from the `2.x` branch of the `logging-log4j2` repository and incorporate it >>> into `/pom.xml` of `log4j-kotlin`. Try to place it exactly at the same >>> location: right after `revision`. >>> >>> I might sound pedantic about this and I am. I try really hard to make >>> all `pom.xml`s look alike to avoid the surprise factor maintainers suffer >>> from while jumping from one project to another. Not to mention this also >>> helps us to carry out automation, e.g., `project.build.outputTimestamp` is >>> replaced by `logging-parent` CI magic during release. >>> >>> >> Done >> >> >>> *Remove `cyclonedx-maven-plugin` override* >>> >>> Remove the `cyclonedx-maven-plugin` override (and the comment block >>> preceding it) from `/pom.xml`. This is not necessary anymore with the >>> `logging-parent` version `0.4.0` release. >>> >> >> Done >> >> >>> >>> *Changelog cleanup* >>> >>> Make sure `src/changelog/.1.x.x` contents look good. You can verify this >>> by skimming through `src/site` after issuing a `./mvnw process-sources`. >>> >>> Could you update all changelog XSDs to version `0.1.2` too, please? >>> >>> I would also appreciate it if you can remove all `author` elements from >>> `src/changelog/*/*.xml` files. They are neither rendered by the template, >>> nor provide information that one cannot obtain from the associated >>> commit/ticket. >>> >> >> Done >> >> >>> >>> *Generated emails* >>> >>> Please don't send generated emails verbatim! Nexus URLs need to be >>> manually filled in and there are always some minor formatting details to >>> fix in the text. >>> >> >> Will keep this in mind. >> >> Thanks, >> Raman >> >> >
