On 2024/01/10 09:27:22 Volkan Yazıcı wrote:
> Thanks for chasing this Ralph, it is indeed a nice step forwards.
>
> The aforementioned Log4j issue is fixed in #2062
> <https://github.com/apache/logging-log4j2/pull/2062>:
>
> 1. You submitted the PR on Dec 5 at 04:15 (GMT+1) and merged it at
> 05:58. Next time, would you mind giving us a couple of days for the review,
> please?
AFAIK we are still doing CTR. Usually I would have just committed this directly
but since we need something to track in the release notes I decided to create a
PR. If I had thought this to be anything more than a straightforward bug fix I
would have asked for a review and waited.
> 2. Piotr and I both reviewed the changes and we had remarks. None of
> them have been addressed so far. Would you mind responding to them, please?
> (See the PR for the comments.)
Sure. I apologize that I didn't notice the remarks due to the sheer volume of
email I get from GitHub.
> 3. Could you backport the fix to `2.x` branch too, please?
I could. I am still debating whether we should. It still isn't clear to me how
much more has to be done to release 3.0.0. Once that is out we should be
encouraging Spring 3.x users to upgrade to Log4j 3.
Ralph
