Gary has a failure on L361, that is, it retries every 100ms to succeed with `logger.info()` for at most 2mins. I doubt if more waiting will solve the problem. I tried to improve that test several times (see its history), but Windows just behaves weird with sockets. I'd appreciate it if Windows users can share some tips on what else we can do.
Piotr, you say "a proven history of flakiness", but the link you shared states, out of 1.26k times, in the last 90 days, it has failed only 2 times, and was flaky only 16 times. What is our definition of flakiness here? On Mon, Sep 16, 2024 at 7:09 PM Piotr P. Karwasz <piotr.karw...@gmail.com> wrote: > Hi Gary, > > On Mon, 16 Sept 2024 at 16:50, Gary D. Gregory <ggreg...@apache.org> > wrote: > > > > I just pulled main since we've had changes there, now I get: > > > > [ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 15.31 s <<< FAILURE! -- in > org.apache.logging.log4j.core.appender.SocketAppenderReconnectTest > > [ERROR] > org.apache.logging.log4j.core.appender.SocketAppenderReconnectTest.repeating_reconnect_failures_should_be_propagated > -- Time elapsed: 3.323 s <<< ERROR! > > org.apache.logging.log4j.core.appender.AppenderLoggingException: Error > writing to TCP:localhost:57111 for connection localhost/127.0.0.1:57111 > > This is a test with a proven history of flakiness[1]. I guess we need > to add more conditions to the test (e.g. wait until the server > received a connection request from the client). > > Piotr > > [1] > https://ge.apache.org/scans/tests?search.relativeStartTime=P90D&search.rootProjectNames=Apache%20Log4j%20BOM&search.timeZoneId=Europe%2FWarsaw&tests.container=org.apache.logging.log4j.core.net.SocketAppenderReconnectTest# >
