Thanks for the heads up, Robert! Fixed in eaab90254946715f690e60d5b33f15eca43dcefd <https://github.com/apache/logging-log4cxx/commit/eaab90254946715f690e60d5b33f15eca43dcefd> .
On Wed, Oct 16, 2024 at 1:06 PM Robert Middleton <rmiddle...@apache.org> wrote: > Notes(none of these are blockers): > * Fuzzing page doesn't render > correctly(https://logging.staged.apache.org/log4cxx/1.3.0/fuzzing.html) > * The review kit link leads to a 404?? > * SHA256 sums are not needed, but it doesn't hurt to add. I checked > only the SHA512 sums. > * The new release is missing a few files that were in the 1.2.0 > release, but those are all github/administrative files so it doesn't > cause an issue > > Checksums/signatures are good > Builds and runs(tests pass) on Debian 11. > I checked the files from SVN > > Looks good to me. +1 > > -Robert Middleton > > On Tue, Oct 15, 2024 at 3:21 AM Piotr P. Karwasz > <piotr.karw...@gmail.com> wrote: > > > > Hi Stephen, > > > > On Tue, 15 Oct 2024 at 06:33, Stephen Webb <swebb2...@gmail.com> wrote: > > > Please download, test, and cast your votes on this mailing list. > > > > > > [ ] +1, release the artifacts > > > [ ] -1, don't release, because ... > > > > +1, release the artifacts > > > > I ran the build on my Debian system: > > > > piotr@migi:~$ uname -a > > Linux migi 6.1.0-18-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.76-1 > > (2024-02-01) x86_64 GNU/Linux > > piotr@migi:~$ cat /etc/debian_version > > 12.7 > > piotr@migi:~$ LANG= apt policy libapr1 libaprutil1 > > libapr1: > > Installed: 1.7.2-3 > > Candidate: 1.7.2-3 > > Version table: > > *** 1.7.2-3 500 > > 500 https://deb.debian.org/debian bookworm/main amd64 Packages > > 100 /var/lib/dpkg/status > > libaprutil1: > > Installed: 1.6.3-1 > > Candidate: 1.6.3-1 > > Version table: > > *** 1.6.3-1 500 > > 500 https://deb.debian.org/debian bookworm/main amd64 Packages > > 100 /var/lib/dpkg/status > > piotr@migi:~/workspace/rc/log4cxx-1.3.0$ g++ --version > > g++ (Debian 12.2.0-14) 12.2.0 > > Copyright (C) 2022 Free Software Foundation, Inc. > > This is free software; see the source for copying conditions. There is > NO > > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR > PURPOSE. > > > > I checked: > > > > 1. The hashes and signature of the files in SVN. > > 2. Ran the build and tests using both source archives. The effective > > configuration was: > > -- Available appenders: > > -- Async Appender .................. : ON > > -- ODBC Appender ................... : OFF > > -- DB Appender ..................... : ON > > -- SMTP Appender ................... : OFF > > -- XMLSocketAppender ............... : ON > > -- SocketHubAppender ............... : ON > > -- SyslogAppender .................. : ON > > -- Using syslog.h .................. : ON > > -- TelnetAppender .................. : ON > > -- NTEventLogAppender .............. : OFF > > -- OutputDebugStringAppender ....... : ON > > -- ConsoleAppender ................. : ON > > -- FileAppender .................... : ON > > -- RollingFileAppender ............. : ON > > -- MultiprocessRollingFileAppender . : OFF > > -- Available layouts: > > -- HTMLLayout ...................... : ON > > -- JSONLayout ...................... : ON > > -- PatternLayout ................... : ON > > -- SimpleLayout .................... : ON > > -- XMLLayout ....................... : ON > > -- FMTLayout ....................... : OFF > > 3. Verified that the files attached to > > https://github.com/apache/logging-log4cxx/actions/runs/11049448312 are > > the same as in the SVN repo. > > > > Piotr >
