Hi All, Thank you Piotr for managing this release.
[1] https://github.com/apache/logging-log4j2/issues/3143 This issue points to the merged PR https://github.com/apache/logging-log4j2/pull/2936, a large change set with zero tests. This isn't great since there are no tests to catch regressions :-( [2] https://github.com/apache/logging-log4j2/pull/3209 LGTM: If I apply the patch, the test is green, then when I revert the 'main' changes, the test fails. Nice work :-) [3] https://github.com/apache/logging-log4j2/pull/3210 LGTM: If I apply the patch, the 2 tests are green, then when I revert the 'main' changes, the 2 tests fail. Nice work :-) So it all looks good :-) HTH, Gary On Sat, Nov 16, 2024 at 4:35 AM Piotr P. Karwasz <pi...@mailing.copernik.eu> wrote: > Hi all, > > Due to bug #3143[1], which allows a `Logger` to be garbage-collected > before it is returned by `LoggerContext#getLogger()`, I am planning a > 2.24.2 release with just two changes: > > * A fix for the above mentioned bug (see PR #3209[2]). > > * A fix for a bug related to `ThreadContextMap` (see PR #3210[3]). > > Could you check those PRs to make sure we don't miss anything this time? > I am planning the release for Sunday evening or Monday morning, but I'll > wait until those PRs have reviews. > > Piotr > > [1] https://github.com/apache/logging-log4j2/issues/3143 > > [2] https://github.com/apache/logging-log4j2/pull/3209 > > [3] https://github.com/apache/logging-log4j2/pull/3210 > >
