[
https://issues.apache.org/jira/browse/LUCENE-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2416:
-------------------------------
Attachment: LUCENE-2416.patch
* Removed unrelated jdoc in DirContentSource
* LongToEnglishContentSource - added jdoc, improved synchronization, added ASF
license
* WriteLineDocTask is now threadsafe - uses PrintWriter and a ThreadLocal for
threads buffer
* Added relevant test to WriteLineDocTaskTest
* Deleted Format.simpleName(Class) and replaced by class.getSimpleName()
* Handled 3.0 TODOs:
** Renamed StringBufferReader to StringBuilderReader
** Changed to use StringBuilder in TrecContentSource
In order to apply the patch you need to first:
svn mv
lucene/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/utils/StringBufferReader.java
lucene/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/utils/StringBuilderReader.java
All benchmark tests pass. I plan to commit shortly.
> Some improvements to Benchmark
> ------------------------------
>
> Key: LUCENE-2416
> URL: https://issues.apache.org/jira/browse/LUCENE-2416
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2416.patch
>
>
> I've noticed that WriteLineDocTask declares it does not support
> multi-threading, but taking a closer look I think this is really for no good
> reason. Most of the work is done by reading from the ContentSource and
> constructing the document. If those two are mult-threaded (and I think all
> ContentSources are), then we can synchronize only around writing the actual
> document to the line file.
> While investigating that, I've noticed some 1.5 TODOs and some other minor
> improvements that can be made. If you've wanted to make some minor
> improvements to benchmark, let me know :). I intend to include only minor and
> trivial ones.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
